Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ready] [medium] Fix various issues with listelements and fabrikmodalrepeat form fields. #1960

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[ready] [medium] Fix various issues with listelements and fabrikmodalrepeat form fields. #1960

wants to merge 3 commits into from

Commits on Feb 9, 2018

  1. Intelligent insert into text field when mode=gui... 

    ... e,g, in databasejoin element advanced tab for inserting description
fields.

1. Position caret at end when initialising
2. Add whitespace as needed around value to avoid concatenation with
existing strings.

This is not a complete fix as e.g. if user positions caret in the middle
of an element name, then inserting a new element name will split the
existing one. This should probably be an HTML list field rather than a
text field, but this is still better than existing.
    @Sophist-UK
    Sophist-UK committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    4a1ef9d View commit details
    Browse the repository at this point in the history

  2. Get direct parent of the table... 

    ... so that we can put the table back in the same place it came from
when the fabrikmodalrepeat is closed.
    @Sophist-UK
    Sophist-UK committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    58349bc View commit details
    Browse the repository at this point in the history

  3. Misc minor fixes.

    @Sophist-UK
    Sophist-UK committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    263efed View commit details
    Browse the repository at this point in the history