Sanitize tag, item, and mod inputs #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xbony2
reviewed
Aug 11, 2017
special/OreDictEntryManager.php
Outdated
| if ($result == false) { | ||
| return -2; | ||
| } | ||
| return $result; |
There was a problem hiding this comment.
Also loosely checking against false in PHP, while rare, could end in disaster.
There was a problem hiding this comment.
Come to think about it, in Java the syntax would be !$results although I suspect that's not a possible thing in PHP.
There was a problem hiding this comment.
return ($result === false ? -2 : $result);
There was a problem hiding this comment.
@Alexia Is that check loose? I thought === false would be "loose" while == false would be strictly checking against false.
OreDict#addEntry returns either false or the entry ID. Is this a poor way to handle this?
Edit: Never mind, Peter corrected me. I had it flipped around in my head.
|
This seems fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #53.
@Alexia Could you review this and perhaps double check that I haven't missed any areas where input sanitation is needed?