Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New FSH Publisher + v1.18.0 #90

Merged
merged 4 commits into from
Sep 19, 2024
Merged

New FSH Publisher + v1.18.0 #90

merged 4 commits into from
Sep 19, 2024

Conversation

jafeltra
Copy link
Collaborator

Description: This PR adds the new publisher and bumps the version of the extension.

This branch will be merged into master and then can be published to the new publisher.

Testing Instructions: Make sure I didn't miss an instance of the old publisher.

I believe I can also just publish the extension to the new publisher since that won't affect the old publisher and current extension. If anyone wants to see that as part of testing, let me know.

Related Issue: N/A

cmoesel
cmoesel previously approved these changes Sep 18, 2024
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! It looks like you switched over all the relevant code. Tests still pass and extension runs in the debugger.

@jafeltra jafeltra changed the title New FSH Publisher New FSH Publisher + v1.18.0 Sep 19, 2024
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice shiny new publisher.

Copy link
Collaborator

@mint-thompson mint-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, thank you!

@jafeltra jafeltra merged commit b0a4b39 into master Sep 19, 2024
14 checks passed
@jafeltra jafeltra deleted the new-fsh-publisher branch September 19, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants