Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to test definitions and add core tag to mandatory functionality #254

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

johngrimes
Copy link
Collaborator

This change adds a new "tags" element to a test definition.

It also uses this feature to define a "core" set of tests that cover the mandatory functionality, and boundary and join functions have been left out of this.

@johngrimes johngrimes requested review from niquola and rbrush August 6, 2024 19:06
@johngrimes johngrimes marked this pull request as draft August 26, 2024 23:46
@johngrimes
Copy link
Collaborator Author

I will have a go at modifying this pull request to represent all the changes noted here: https://chat.fhir.org/#narrow/stream/179219-analytics-on-FHIR/topic/Proposal.20for.20documenting.20.22core.22.20vs.20other.20functionality/near/462650241

operators: [equals (=)](https://hl7.org/fhirpath/#equals), [not equals (!=)](https://hl7.org/fhirpath/#not-equals), [greater than (>)](https://hl7.org/fhirpath/#greater-than), [less or equal (<=)](https://hl7.org/fhirpath/#less-or-equal)
- [Indexer expressions](https://hl7.org/fhirpath/#index-integer-collection)

### Experimental FHIRPath Functions
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure how to do a "big yellow box", but maybe this is good enough for now.

@johngrimes johngrimes marked this pull request as ready for review August 27, 2024 01:25
@johngrimes
Copy link
Collaborator Author

@niquola @rbrush I'm done modifying this to represent what we captured in the meeting, let me know if you have any feedback.

@johngrimes johngrimes added this to the v2.0.0 milestone Aug 27, 2024
@johngrimes
Copy link
Collaborator Author

Haven't got any feedback on this, so I think I'm going to go ahead and merge this now.

@johngrimes johngrimes merged commit ecb80c7 into master Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant