Skip to content

Commit

Permalink
Merge pull request #235 from bashir2/implementation
Browse files Browse the repository at this point in the history
Added OHS implementation
  • Loading branch information
johngrimes authored May 2, 2024
2 parents 419872a + 33b0f1a commit 0761d5e
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 40 deletions.
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,10 @@ the process of publishing your test report and registering your implementation.
### Registering Your Implementation

Once your test report is published and accessible, the final step is to register
your implementation in the `./implementations.json` file. This file serves as a
registry of available implementations and their test results, facilitating
discovery and comparison.
your implementation in the
[`test_report/public/implementations.json`](test_report/public/implementations.json)
file. This file serves as a registry of available implementations and their test
results, facilitating discovery and comparison.

1. **Format of `implementations.json`**:
- The `implementations.json` file is a JSON document that lists implementations along with URLs to their test reports.
Expand Down
30 changes: 0 additions & 30 deletions implementations.json

This file was deleted.

4 changes: 2 additions & 2 deletions test_report/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
Install the dependencies...

```bash
cd svelte-app
npm install
```

...then start [Rollup](https://rollupjs.org):
...then start [Rollup](https://rollupjs.org) (you need to have
[Bun](https://bun.sh/docs/installation) installed as well) :

```bash
npm run dev
Expand Down
9 changes: 5 additions & 4 deletions test_report/public/implementations.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"name": "Aidbox",
"url": "https://docs.aidbox.app/storage-1/sql-on-fhir",
"description": "FHIR++ Platform by Health Samurai",
"testResultsUrl": "https://storage.googleapis.com/aidbox-public/sof-test-results.json"
"testResultsUrl": "https://storage.googleapis.com/aidbox-public/aidbox-sof-test-results.json"
},
{
"name": "Pathling",
Expand All @@ -18,9 +18,10 @@
"testResultsUrl": "https://pathling.csiro.au/test-results/refs/heads/issue/1759/sof-test-results.json"
},
{
"name": "Google",
"url": "TBD",
"description": "TBD"
"name": "Google (Open Health Stack)",
"url": "https://developers.google.com/open-health-stack/fhir-analytics/data-pipes",
"description": "OHS's fhir-data-pipes offers an option to use ViewDefinitions for creating 'flat tables' from FHIR resources. The actual implementation is in this package: https://github.com/google/fhir-data-pipes/tree/master/pipelines/common/src/main/java/com/google/fhir/analytics/view",
"testResultsUrl": "https://raw.githubusercontent.com/google/fhir-data-pipes/master/pipelines/common/src/test/resources/sql-on-fhir-v2-test-result.json"
},
{
"name": "Grahame Impl",
Expand Down
2 changes: 1 addition & 1 deletion test_report/src/Impls.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
import { onMount } from "svelte";
import implementations from '../../implementations.json';
import implementations from '../public/implementations.json';
import tests from '../public/tests.json';
async function load(file){
Expand Down

0 comments on commit 0761d5e

Please sign in to comment.