Avoid using Dirent.path and Dirent.parentPath properties #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lable in earlier Node 18.x versions Dirent.path was added in Node 18.17.0 and then deprecated in Node 18.20.0. Dirent.parentPath was added in Node 18.20.0. In order to keep compatibility with versions of Node before 18.17.0, don't use Dirent.path or Dirent.parentPath.
|
Breaking the glass (no peer code reviews) to get this urgent bug fix out ASAP (on the weekend). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Dirent.pathwas added in Node 18.17.0 and then deprecated in Node 18.20.0.Dirent.parentPathwas added in Node 18.20.0. In order to keep compatibility with versions of Node before 18.17.0, don't useDirent.pathorDirent.parentPath.Using
Dirent.parentPathresulted in errors when SUSHI was run on earlier versions of Node 18.x. See: https://chat.fhir.org/#narrow/channel/215610-shorthand/topic/Issue.20w.2F.20newest.20SUSHI/near/490266928Testing Instructions: Run
npm teston the main branch using a Node 18 version < Node 18.17 (e.g, Node 18.16.0). You will get errors like: TypeError: The "path" argument must be of type string. Received undefined. Now run this PR branch using the same version of Node (e.g., Node 18.16.0). The tests should all pass.