Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename newSQLJSPackageDB to createSQLJSPackageDB #47

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Rename newSQLJSPackageDB to createSQLJSPackageDB #47

merged 1 commit into from
Dec 17, 2024

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Dec 17, 2024

Description: Rename newSQLJSPackageDB function to createSQLJSPackageDB after discussion with the team.

Testing Instructions: Ensure tests all pass.

Related Issue: N/A

jafeltra
jafeltra approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have created greatness.

@cmoesel
Copy link
Member Author

cmoesel commented Dec 17, 2024

Thank you, @jafeltra. That means a lot.

@cmoesel cmoesel merged commit 84cca1b into main Dec 17, 2024
14 checks passed
@cmoesel cmoesel deleted the rename-sqljs-factory-method branch December 17, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafeltra jafeltra jafeltra approved these changes

@mint-thompson mint-thompson Awaiting requested review from mint-thompson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmoesel @jafeltra