Unit tests for registry clients #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoesel
requested changes
Jul 19, 2024
…istry client tests, add in versioning check to npm client, cleanup
KaelynJefferson
commented
Jul 23, 2024
cmoesel
requested changes
Jul 26, 2024
KaelynJefferson
commented
Aug 6, 2024
cmoesel
requested changes
Aug 7, 2024
cmoesel
approved these changes
Aug 7, 2024
cmoesel
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Added final test, minor test title change within DiskBasedPackageCache unit tests * Adding unit tests for FHIRRegistryClient * missing mock test parts, styling * prettier fixes to unmodified files * Adding DefaultRegistryClient unit tests * separated constructor tests into own group * Adding redundant registry client tests * adding default registry client tests * adding npm registry client tests, small modification to npm client * Adding additional tests, error checking within client * prettier fix to diskbased client * removing one test in default client * cleanup, await expect * cleanup, await expect, some test fixes * cleanup, await expect * pull common tests into registryClientHelper, sync up fhir and npm registry client tests, add in versioning check to npm client, cleanup * clean up tests for registry clients, rename registry utils * comment out logging bug * removing multi client test from default registry client * removed unnecessary await before log check
cmoesel
pushed a commit
that referenced
this pull request
Dec 2, 2024
cmoesel
pushed a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes unit tests for clients in the Registry folder and some modifications to their corresponding classes:
To test: jest/npm
Related Issue: n/a