Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCx24 Release #915

Merged
merged 29 commits into from
Nov 19, 2024
Merged

OCx24 Release #915

merged 29 commits into from
Nov 19, 2024

Conversation

brookwander
Copy link
Collaborator

Release for OCX24 dataset and manuscript.

@brookwander brookwander added enhancement New feature or request minor Minor version release labels Nov 15, 2024
@mshuaibii mshuaibii changed the title Ocx OCx24 Release Nov 15, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

🚨 Try these New Features:

@mshuaibii
Copy link
Collaborator

Let's also create a package for it here - https://github.com/FAIR-Chem/fairchem/tree/ocx/packages. Specifically adding the dependencies we used here.

mshuaibii
mshuaibii previously approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@mshuaibii mshuaibii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -

Let's merge once we have the arxiv link and upload the missing synthesis file.

@mshuaibii mshuaibii enabled auto-merge November 19, 2024 03:48
@mshuaibii mshuaibii added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit aa298ac Nov 19, 2024
8 checks passed
@mshuaibii mshuaibii deleted the ocx branch November 19, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshuaibii mshuaibii mshuaibii approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request minor Minor version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brookwander @mshuaibii