Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mean e to escn energy head #828

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Add mean e to escn energy head #828

merged 2 commits into from
Sep 5, 2024

Conversation

rayg1234
Copy link
Collaborator

@rayg1234 rayg1234 commented Sep 4, 2024

Similar to this we need the mean energy for escn as well:
#818

@rayg1234 rayg1234 added enhancement New feature or request patch Patch version release labels Sep 4, 2024
@rayg1234 rayg1234 marked this pull request as ready for review September 4, 2024 18:28
@rayg1234 rayg1234 requested review from misko and wood-b September 4, 2024 18:28
wood-b
wood-b approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@wood-b wood-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rayg1234 rayg1234 enabled auto-merge September 4, 2024 18:47
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/models/escn/escn.py 57.14% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/models/escn/escn.py 95.86% <57.14%> (-0.69%) ⬇️

@rayg1234 rayg1234 disabled auto-merge September 4, 2024 21:42
@rayg1234 rayg1234 enabled auto-merge September 4, 2024 21:42
@misko misko self-requested a review September 4, 2024 23:17
@rayg1234 rayg1234 added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 35eb115 Sep 5, 2024
9 checks passed
@rayg1234 rayg1234 deleted the rgao_add_mean_energy_to_escn branch September 5, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wood-b wood-b wood-b approved these changes

@misko misko misko approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayg1234 @misko @wood-b