Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use abs run_dir paths by default #820

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Use abs run_dir paths by default #820

merged 1 commit into from
Aug 22, 2024

Conversation

rayg1234
Copy link
Collaborator

@rayg1234 rayg1234 commented Aug 21, 2024

This makes it easier to find people's checkpoints and logs given a W&B run

Currently no idea where these files are :(
image

Now:
image

we should also add a config line that identifies which cluster the job is on

@rayg1234 rayg1234 marked this pull request as ready for review August 21, 2024 22:02
@rayg1234 rayg1234 requested a review from misko August 21, 2024 22:02
@rayg1234 rayg1234 added the patch Patch version release label Aug 21, 2024
@rayg1234 rayg1234 enabled auto-merge August 21, 2024 22:07
@rayg1234 rayg1234 added the enhancement New feature or request label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/fairchem/core/common/flags.py 100.00% <100.00%> (ø)

@rayg1234 rayg1234 added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit df89330 Aug 22, 2024
8 of 10 checks passed
@rayg1234 rayg1234 deleted the rgao_use_abs_run_path branch August 22, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants