Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gemnet scaling factors fit.py and add a test #819

Merged
merged 3 commits into from
Aug 22, 2024
Merged

fix gemnet scaling factors fit.py and add a test #819

merged 3 commits into from
Aug 22, 2024

Conversation

misko
Copy link
Collaborator

@misko misko commented Aug 21, 2024

No description provided.

@misko misko requested review from rayg1234 and wood-b August 21, 2024 20:34
@misko misko added enhancement New feature or request patch Patch version release labels Aug 21, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Files Patch % Lines
src/fairchem/core/modules/scaling/fit.py 58.82% 7 Missing ⚠️
Files Coverage Δ
src/fairchem/core/modules/scaling/fit.py 71.90% <58.82%> (ø)

... and 4 files with indirect coverage changes

@misko misko enabled auto-merge August 21, 2024 22:30
wood-b
wood-b approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@wood-b wood-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@misko misko added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit c2b0c30 Aug 22, 2024
8 checks passed
@misko misko deleted the update_gemnet_fit_scaling_factors branch August 22, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wood-b wood-b wood-b approved these changes

@rayg1234 rayg1234 Awaiting requested review from rayg1234

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misko @wood-b