Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to clip grad by value #810

Closed
wants to merge 3 commits into from
Closed

add option to clip grad by value #810

wants to merge 3 commits into from

Conversation

misko
Copy link
Collaborator

@misko misko commented Aug 14, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/trainers/base_trainer.py 87.50% 1 Missing ⚠️
Files with missing lines Coverage Δ
...re/models/equiformer_v2/trainers/forces_trainer.py 57.14% <100.00%> (+1.26%) ⬆️
src/fairchem/core/trainers/base_trainer.py 89.09% <87.50%> (-0.13%) ⬇️

@misko misko added enhancement New feature or request patch Patch version release labels Aug 15, 2024
@misko misko requested a review from rayg1234 August 15, 2024 21:08
@misko misko marked this pull request as ready for review August 15, 2024 21:08
@rayg1234
Copy link
Collaborator

lgtm, did you see any benefit of trying this?

@github-actions GitHub Actions
Copy link

This PR has been marked as stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added stale and removed stale labels Sep 21, 2024
@github-actions GitHub Actions
Copy link

This PR has been marked as stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added stale and removed stale labels Oct 23, 2024
@github-actions GitHub Actions
Copy link

This PR has been marked as stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 23, 2024
@github-actions github-actions bot closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayg1234 rayg1234 Awaiting requested review from rayg1234

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misko @rayg1234