Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example hydra config #799

Merged
merged 9 commits into from
Aug 16, 2024
Merged

add example hydra config #799

merged 9 commits into from
Aug 16, 2024

Conversation

misko
Copy link
Collaborator

@misko misko commented Aug 8, 2024

Add a eSCN hydra config example

@misko misko requested review from rayg1234 and lbluque August 8, 2024 17:30
Copy link
Collaborator

@lbluque lbluque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @misko !

Can you move this to the top level configs directory and name it something like hydra_example.yml so its clear. Ideally if you can add a few comments just describing the options (similar to the ocp_example.yml) that would be great!

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@misko
Copy link
Collaborator Author

misko commented Aug 13, 2024

Thanks @misko !

Can you move this to the top level configs directory and name it something like hydra_example.yml so its clear. Ideally if you can add a few comments just describing the options (similar to the ocp_example.yml) that would be great!

I moved it and changed to eSCN hydra instead of equiformer v2 , just to reduce the number of lines in the config and make it easier to see where hydra + heads are

@misko misko added the enhancement New feature or request label Aug 13, 2024
@misko misko enabled auto-merge August 13, 2024 18:48
@misko misko added the patch Patch version release label Aug 15, 2024
@misko misko requested a review from lbluque August 15, 2024 21:19
@lbluque lbluque added documentation Improvements or additions to documentation and removed enhancement New feature or request patch Patch version release labels Aug 15, 2024
@misko misko added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 96cf75d Aug 16, 2024
8 of 11 checks passed
@misko misko deleted the add_example_hydra_eqv2_config branch August 16, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants