Allow symlink'd experimental folder by using absolute and not resolved paths #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulissimeta
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
zulissimeta
added
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we ask developers to put dev code into
fairchem/src/fairchem/experimental. These paths are then loaded automatically. The current code resolves any paths, so iffairchem/src/fairchem/experimentalis a symlink (say to a github repo cloned elsewhere) the crawler will fail as the paths do not look relative to the fairchem root.This PR would remove the
.resolve()calls (replacing with.absolute()where appropriate) in the import so that the folder will be crawled without resolving symlinks.