Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NEB doc notebooks #773

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Fix NEB doc notebooks #773

merged 8 commits into from
Jul 19, 2024

Conversation

brookwander
Copy link
Collaborator

No description provided.

brookwander and others added 2 commits July 16, 2024 17:21
…unami enumeration (#764)

* adding new notebook for using fairchem models with NEBs

* adding md tutorials

* blocking code cells that arent needed or take too long
@brookwander brookwander requested a review from zulissimeta July 18, 2024 16:04
zulissimeta
zulissimeta previously approved these changes Jul 18, 2024
Copy link
Collaborator

@zulissimeta zulissimeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brookwander brookwander linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

zulissimeta
zulissimeta previously approved these changes Jul 18, 2024
Copy link
Collaborator

@zulissimeta zulissimeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added one small suggestion to make the seed's purpose more clear

docs/tutorials/NRR/NRR_example.md Outdated Show resolved Hide resolved
zulissimeta
zulissimeta previously approved these changes Jul 18, 2024
@zulissimeta zulissimeta enabled auto-merge July 18, 2024 18:25
@zulissimeta zulissimeta added this pull request to the merge queue Jul 18, 2024
@brookwander brookwander removed this pull request from the merge queue due to a manual request Jul 18, 2024
zulissimeta
zulissimeta previously approved these changes Jul 18, 2024
Copy link
Collaborator

@zulissimeta zulissimeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zulissimeta zulissimeta added this pull request to the merge queue Jul 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 18, 2024
@mshuaibii mshuaibii dismissed zulissimeta’s stale review July 18, 2024 23:36

The merge-base changed after approval.

@mshuaibii mshuaibii changed the title updating approach to path to work with ipython Fix NEB doc notebooks Jul 19, 2024
mshuaibii
mshuaibii previously approved these changes Jul 19, 2024
@mshuaibii mshuaibii added this pull request to the merge queue Jul 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 19, 2024
@mshuaibii mshuaibii added this pull request to the merge queue Jul 19, 2024
@mshuaibii mshuaibii removed this pull request from the merge queue due to a manual request Jul 19, 2024
@mshuaibii mshuaibii added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 33ebf3d Jul 19, 2024
7 checks passed
@mshuaibii mshuaibii deleted the new-cattsunami-nb branch July 19, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEB notebook broken
3 participants