Fix dataset logic

[lbluque]

These two lines edited in #742

fairchem/src/fairchem/core/trainers/base_trainer.py

Line 310 in 5743a59

if self.config["val_dataset"]:

fairchem/src/fairchem/core/trainers/base_trainer.py

Line 332 in 5743a59

if self.config["test_dataset"]:

would set val and test datasets to have the same "src" as the training set in cases where they are not defined at all in a config. An explicit check that their own "src" is defined should fix the issue.

[codecov]

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Files	Coverage Δ
src/fairchem/core/trainers/base_trainer.py	85.53% <78.57%> (+0.06%)	⬆️

[zulissimeta]

This makes sense to me. Thanks for catching!

A lot of this would be cleaner if we had the configs sanitized and/or forced to follow a convention. We should probably do that at some point.

[lbluque]

blocked by #770

The merge-base changed after approval.

[zulissimeta]

Still LGTM =)