Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding fields for #894 #896

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

K-ETFreeman
Copy link

solves #894

Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the integration tests to check the permissions for updates works for these fields.

@K-ETFreeman
Copy link
Author

Can you add the integration tests to check the permissions for updates works for these fields.

You mean writing another .java file like this?
image
MatchmakerQueueMapPoolElideTest.java?

@Sheikah45
Copy link
Member

Yes

@K-ETFreeman
Copy link
Author

MatchmakerQueueMapPoolElideTest.java

i also should probably write prepMatchmakerQueueMapPoolData.sql then

@K-ETFreeman
Copy link
Author

seeing -- matchmaker_queue is populated by R__070_matchmaker_queue.sql from Flyway comment tho, not sure

@K-ETFreeman
Copy link
Author

Yes

image
hm
where API gets data about db schema? i was thinking from commons but seems like not

@Brutus5000
Copy link
Member

private static final GenericContainer<?> flywayMigrationsContainer = new GenericContainer<>("faforever/faf-db-migrations:v133");

@Brutus5000
Copy link
Member

And at runtime here

schema-version: ${DATABASE_SCHEMA_VERSION:133}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants