Add gameId column to LeagueScoreJournal

[BlackYps]

Requires league service 1.5.0

With this the loginId and gameId just exist as integers. They don't have a relationship to the actual object with that Id. How can this be added given that we would cross databases with this?

[codecov]

Codecov Report

Merging #772 (ec4653f) into develop (0d570f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop     #772   +/-   ##
==========================================
  Coverage      78.01%   78.02%           
- Complexity      1262     1263    +1     
==========================================
  Files            249      249           
  Lines           3812     3813    +1     
  Branches         241      241           
==========================================
+ Hits            2974     2975    +1     
  Misses           738      738           
  Partials         100      100           

Files Changed	Coverage Δ
...aforever/api/league/domain/LeagueScoreJournal.java	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d570f5...ec4653f. Read the comment docs.

[bukajsytlos]

lgtm

[Brutus5000]

They don't have a relationship to the actual object with that Id. How can this be added given that we would cross databases with this?

To our knowledge you can't and have to do 2 queries instead. I raised the question in the Elide Discord though. Although I recently discovered in MySQL you can cross join databases if you prefix the tables with the db name. Not sure if this is supported by Hibernate, then we could just drop the Multiplex store altogether...

[BlackYps]

Is doing two queries still the way to go?

[Brutus5000]

Currently yes, but I found a way that MySQL can do crossover joins if a user actually has permissions for both tables.
So we could actually drop the 2nd elide datastore and then we could do regular elide joins again. But time time time. :(