Fix for device_id exception raised when creating Neutron network port in HPB #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HPB) Issues: Fixes F5Networks#930 Problem: create_port_on_network() fails to set a device_id in port data unless one is passed into the function. Because the agent calls this method without a device_id it will always fail. Analysis: Code was recently changed so that the passed in device_id is always used, but failed to account for situations when device_id is not given. Added additional code to set device_id to a uuid ID when no device_id is given. Tests:
ssorenso
approved these changes
Jun 5, 2018
f5lbaasdriver/v2/bigip/plugin_rpc.py
Outdated
| @@ -536,6 +538,8 @@ def create_port_on_subnet(self, context, subnet_id=None, | |||
|
|
|||
| if device_id: | |||
| port_data['device_id'] = device_id | |||
| else: | |||
| port_data['device_id'] = str(uuid.uuid5(uuid.NAMESPACE_DNS, str(host))) | |||
There was a problem hiding this comment.
@jlongstaf - flake is complaining that this and it's sister line at 708 are too long (exceeds 80 character limit).
Otherwise, it looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Fixes #930
Problem: create_port_on_network() fails to set a device_id in
port data unless one is passed into the function. Because the
agent calls this method without a device_id it will always
fail.
Analysis: Code was recently changed so that the passed in device_id
is always used, but failed to account for situations when device_id
is not given. Added additional code to set device_id to a uuid ID
when no device_id is given.