Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application cleanup #113

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Application cleanup #113

merged 1 commit into from
Apr 27, 2018

Conversation

ovv
Copy link
Contributor

@ovv ovv commented Apr 26, 2018

Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92

This also add a timeout argument to dialog.request

Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
@codecov-io
Copy link

Codecov Report

Merging #113 into master will increase coverage by 2.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #113     +/-   ##
=========================================
+ Coverage   71.52%   73.62%   +2.1%     
=========================================
  Files          15       15             
  Lines        1531     1547     +16     
  Branches      265      267      +2     
=========================================
+ Hits         1095     1139     +44     
+ Misses        319      298     -21     
+ Partials      117      110      -7
Impacted Files Coverage Δ
aiosip/dialog.py 77.89% <100%> (+4.39%) ⬆️
aiosip/application.py 77.27% <100%> (+5.46%) ⬆️
aiosip/peers.py 74.13% <0%> (+0.77%) ⬆️
aiosip/utils.py 66.66% <0%> (+2.56%) ⬆️
aiosip/transaction.py 66.21% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 850b6bf...cb6159d. Read the comment docs.

@vodik
Copy link
Contributor

vodik commented Apr 27, 2018

Looks good to me.

@ovv ovv merged commit af98795 into master Apr 27, 2018
@vodik
Copy link
Contributor

vodik commented Apr 27, 2018

So the tag gets added as part of the inbound processing? Okay, I think that might should be okay. Might be a little surprising if you dump the message as you don't see the original message anymore, but should be okay.

@ovv ovv deleted the shutdown branch May 2, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants