Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application cleanup problems #91

Open
2 tasks
vodik opened this issue Mar 30, 2018 · 0 comments
Open
2 tasks

Application cleanup problems #91

vodik opened this issue Mar 30, 2018 · 0 comments
Labels

Comments

@vodik
Copy link
Contributor

vodik commented Mar 30, 2018

This is a combination of a few things I've noticed, and resulted in me pulling the reliable shutdown patch - for now.

My attempt at adding some sort of automatic teardown is fraught with interesting corner cases, but I think also potentially highlighting some issues in our test cases.

  • Test cases hang on shutdown as we often take down the server before the client. Client tries to cleanup nicely and ends up stuck and timing out as there's nowhere to send the appropriate goodbye message to.
  • Proxied traffic is getting torn down incorrectly. When the proxy tests are torn down, order of shutdown matters too. But if the proxy server is torn down first, it, thinking its incorrectly responsible for a dialog, will send an independent shutdown message without the client's knowledge.
@vodik vodik added the bug label Mar 30, 2018
ovv added a commit that referenced this issue Apr 26, 2018
ovv added a commit that referenced this issue Apr 26, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
ovv added a commit that referenced this issue Apr 26, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
ovv added a commit that referenced this issue Apr 26, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
ovv added a commit that referenced this issue Apr 26, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
ovv added a commit that referenced this issue Apr 27, 2018
Imrpove application cleanup. This might need another pass
after #112 is merged

Issue #91 #92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant