-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-pdf
to v9.1.1
#32
Upgrade react-pdf
to v9.1.1
#32
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
86edd1c
to
5e0b60f
Compare
5e0b60f
to
4d97e3d
Compare
@jayeshmangwani this PR is ready for review. We have to update |
@CyberAndrii I was installing the |
I don't think that's important. For example, react-native-live-markdown still uses v18. Ideally, we should also update the other dependencies to match the version in the main repo, but let's leave that for a different PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 🚀
@thienlnam tagging you manually here since the automation doesn't requested your review. Code works well, so can we merge this PR? After that, we can remove the react-fast-pdf patch. |
Details
react-pdf
to v9.1.1@types/react-pdf
dependency asreact-pdf
now natively supports type scriptRelated Issues
Expensify/App#48124
Manual Tests
react-fast-pdf/example/src/App.tsx
Line 9 in caca999
Linked PRs
Expensify/App#49527
Screenshots/Videos
react-fast-pdf.mov