Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-pdf to v9.1.1 #32

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

CyberAndrii
Copy link
Contributor

@CyberAndrii CyberAndrii commented Sep 19, 2024

Details

Related Issues

Expensify/App#48124

Manual Tests

  1. Follow the installation steps in README.md
  2. Comment out this line to avoid pdf moving off-screen bug
    borderStyle: 'solid',
  3. Verify that PDFs open correctly
  4. Enable throttling in dev tools and verify that no errors are printed to the console when cancelling the loading of a pdf

Linked PRs

Expensify/App#49527

Screenshots/Videos

react-fast-pdf.mov

Copy link
Contributor

github-actions bot commented Sep 19, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@CyberAndrii
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@CyberAndrii CyberAndrii force-pushed the 48124-react-pdf-upgrade branch from 86edd1c to 5e0b60f Compare September 19, 2024 10:28
@CyberAndrii CyberAndrii force-pushed the 48124-react-pdf-upgrade branch from 5e0b60f to 4d97e3d Compare September 19, 2024 10:47
@CyberAndrii CyberAndrii marked this pull request as ready for review September 19, 2024 10:48
@CyberAndrii
Copy link
Contributor Author

@jayeshmangwani this PR is ready for review.

We have to update react-fast-pdf package first so we can remove this patch.

@jayeshmangwani
Copy link

@CyberAndrii I was installing the node_modules locally and noticed that we're using Node version 20.10.0 in this repo, while our main repo uses version 20.15.1. Should we update the Node version in the .nvmrc file, or is it fine to leave it as is for now?

@CyberAndrii
Copy link
Contributor Author

I don't think that's important. For example, react-native-live-markdown still uses v18. Ideally, we should also update the other dependencies to match the version in the main repo, but let's leave that for a different PR.

Copy link

@jayeshmangwani jayeshmangwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 🚀

@jayeshmangwani
Copy link

@thienlnam tagging you manually here since the automation doesn't requested your review. Code works well, so can we merge this PR? After that, we can remove the react-fast-pdf patch.

@thienlnam thienlnam merged commit f740457 into Expensify:main Sep 25, 2024
2 checks passed
@CyberAndrii CyberAndrii deleted the 48124-react-pdf-upgrade branch September 26, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants