Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Fix illustration styling for empty view #54577

Merged
merged 2 commits into from
Dec 26, 2024
Merged

[CP Staging] Fix illustration styling for empty view #54577

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b3af86
Apply styling to parent view
MonilBhavsar Dec 25, 2024
7f723ed
Update src/components/EmptySelectionListContent.tsx
jasperhuangg Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/EmptySelectionListContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ function EmptySelectionListContent({contentType}: EmptySelectionListContentProps
);

return (
<ScrollView>
<View style={[styles.flex1, styles.overflowHidden, styles.minHeight65]}>
<ScrollView contentContainerStyle={[styles.flex1, styles.justifyContentCenter]}>
<View style={[styles.overflowHidden, styles.minHeight65]}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ScrollView contentContainerStyle={[styles.flex1, styles.justifyContentCenter]}>
<View style={[styles.overflowHidden, styles.minHeight65]}>
<ScrollView contentContainerStyle={[styles.flexGrow1]}>
<View style={[styles.flex1, styles.overflowHidden, styles.minHeight65]}>

Let's only add styles.flexGrow1 to the ScrollView bcoz flex1 won't show the scrollbar for native if content exceeds.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-26.at.12.15.00.mp4

<BlockingView
icon={Illustrations.ToddWithPhones}
iconWidth={variables.emptySelectionListIconWidth}
Expand Down
Loading