Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Filter mismatch on "Save Search" , Filters page shows the currency selected, but the results do not match the filter. #54474

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix - Filter mismatch on "Save Search" , Filters page shows the currency selected, but the results do not match the filter. #54474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3689458
display results if search already exists
FitseTLT Dec 23, 2024
24a3e8d
Merge branch 'main' into fix-to-show-results-on-saving-already-saved-…
FitseTLT Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/Search/AdvancedSearchFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@
const [reports] = useOnyx(ONYXKEYS.COLLECTION.REPORT);
const [savedSearches] = useOnyx(ONYXKEYS.SAVED_SEARCHES);
const [searchAdvancedFilters = {} as SearchAdvancedFiltersForm] = useOnyx(ONYXKEYS.FORMS.SEARCH_ADVANCED_FILTERS_FORM);
const policyID = searchAdvancedFilters.policyID ?? '-1';

Check failure on line 375 in src/pages/Search/AdvancedSearchFilters.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

const [cardList = {}] = useOnyx(ONYXKEYS.CARD_LIST);
const taxRates = getAllTaxRates();
const personalDetails = usePersonalDetails();
Expand Down Expand Up @@ -434,8 +434,8 @@
const onSaveSearch = () => {
const savedSearchKeys = Object.keys(savedSearches ?? {});
if (!queryJSON || (savedSearches && savedSearchKeys.includes(String(queryJSON.hash)))) {
// If the search is already saved, return early to prevent unnecessary API calls
Navigation.dismissModal();
// If the search is already saved, we only display the results as we don't need to save it.
applyFiltersAndNavigate();
return;
}

Expand Down
Loading