-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal QA]: Add additional navigation for not existing export #54433
base: main
Are you sure you want to change the base?
[Internal QA]: Add additional navigation for not existing export #54433
Conversation
I added logic using backTo to just one connection. There are some other places which should be changed for other connections to use correct go back logic. Also needs to add util function which will return true/false based on check for valid export account (which is available for company card details page menu item). I will be back on Monday 30th and will add all these changes. For now will leave it draft |
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-01-03.at.17.37.21.movAndroid: mWeb ChromeScreen.Recording.2025-01-03.at.17.30.49.moviOS: NativeScreen.Recording.2025-01-03.at.17.36.02.moviOS: mWeb SafariScreen.Recording.2025-01-03.at.17.26.45.movMacOS: Chrome / SafariScreen.Recording.2025-01-03.at.16.43.35.movMacOS: DesktopScreen.Recording.2025-01-03.at.17.43.26.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation of Change
Since you accessed the accounting integration settings from the card-level export, the nav structure tries to bring you back to the card-level export selection page. However, that page is no longer supported based on the new integration settings. I suggest that where you landed on this "no accounts found" page previously when going back, you instead land directly on the card details page, with the card-level export row gone.-->
Fixed Issues
$ #54371
PROPOSAL:
Tests
Offline tests
No changes
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov