Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "The central page page is not rendered when resized to narrow and then to wide view again" #54328

Conversation

s77rt
Copy link
Contributor

@s77rt s77rt commented Dec 18, 2024

Reverts #53466

Copy link
Contributor

🚧 @trjExpensify has triggered a test build. You can view the workflow run here.

Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/54328/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/54328/NewExpensify.dmg https://54328.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@s77rt
Copy link
Contributor Author

s77rt commented Dec 18, 2024

This is not fixing the bug. I think the bug is introduced by #49937 (comment) but we won't be reverting. We have another PR #54329 that should hopefully fix the issue.

@s77rt s77rt closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants