Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new route for profile plan type #52117
Added new route for profile plan type #52117
Changes from 31 commits
6a6e6b1
354e371
fe3d7ad
aa22a9d
a5a0ba0
6e5a07d
cc5de45
bfbe6d1
eb2b373
fc72d50
ca5a6c2
60fc866
02ba6dc
5874d3b
a893592
3ecbd4a
219c274
8757f1e
6dab121
7b6ec22
17241c0
6f3909f
30da5cb
02049cf
580695e
49eb7b1
3382ec4
1066d5d
1778c65
baf3180
c6f8a99
728afd4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using the existing Upgrade page to display the upgrade workspace page when coming from the workspace plan page. Now, we can also navigate from pages that don't have a specific feature.
I've made featureName an optional parameter. If it's not provided, we'll show the common control plan features instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These translations are yet to be confirmed here: https://expensify.slack.com/archives/C01GTK53T8Q/p1731048615013379?thread_ts=1730105986.836259&cid=C01GTK53T8Q
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlosmiceli Before merging, I wanted to let you know that these translations are not yet confirmed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, let's keep these comments open so we can go back to them to see what we have yet to change/merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these translations confirmed here https://expensify.slack.com/archives/C01GTK53T8Q/p1731048615013379?thread_ts=1730105986.836259&cid=C01GTK53T8Q
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we resolve this conversation?