Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist QA email for Fullstory on staging environments #52065

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Whitelist QA email for Fullstory on staging environments #52065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8dcd8aa
adding applause email to const
danieldoglas Nov 5, 2024
60cd0ee
adding logic to fullstory web
danieldoglas Nov 5, 2024
003b382
removing @ from domain
danieldoglas Nov 5, 2024
ce7179b
adding logic to native
danieldoglas Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,6 +1612,7 @@ const CONST = {
CONTRIBUTORS: '[email protected]',
FIRST_RESPONDER: '[email protected]',
GUIDES_DOMAIN: 'team.expensify.com',
QA_DOMAIN: 'applause.expensifail.com',
HELP: '[email protected]',
INTEGRATION_TESTING_CREDS: '[email protected]',
NOTIFICATIONS: '[email protected]',
Expand Down
3 changes: 2 additions & 1 deletion src/libs/Fullstory/index.native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ const FS = {
// after the init function since this function is also called on updates for
// UserMetadata onyx key.
Environment.getEnvironment().then((envName: string) => {
if (envName !== CONST.ENVIRONMENT.PRODUCTION) {
const isTestEmail = value.email !== undefined && value.email.startsWith('fullstory') && value.email.endsWith(CONST.EMAIL.QA_DOMAIN);
if (CONST.ENVIRONMENT.PRODUCTION !== envName && !isTestEmail) {
return;
}
FullStory.restart();
Expand Down
3 changes: 2 additions & 1 deletion src/libs/Fullstory/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ const FS = {
}
try {
Environment.getEnvironment().then((envName: string) => {
if (CONST.ENVIRONMENT.PRODUCTION !== envName) {
const isTestEmail = value.email !== undefined && value.email.startsWith('fullstory') && value.email.endsWith(CONST.EMAIL.QA_DOMAIN);
if (CONST.ENVIRONMENT.PRODUCTION !== envName && !isTestEmail) {
return;
}
FS.onReady().then(() => {
Expand Down
Loading