Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React Native 0.76 #51475

Open
wants to merge 112 commits into
base: main
Choose a base branch
from
Open

Upgrade to React Native 0.76 #51475

wants to merge 112 commits into from
+6,655 −5,848

Conversation

j-piasecki
Copy link
Contributor

@j-piasecki j-piasecki commented Oct 25, 2024 •
edited
Loading

Details

This PR upgrades the version of React Native used in the App to 0.76.

Upstream PRs:

Notes:

Fixed Issues

$ #48911
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

🚧 @mountiny has triggered a test build. You can view the workflow run here.

@github-actions GitHub Actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51475/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51475/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51475/NewExpensify.dmg https://51475.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Expense - Unfunctional Pay button is present on workspace chat expenses in search

Version Number: 9.0.75-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to URL https://51475.pr-testing.expensify.com/ and login with any account.
  2. Create some expenses in a workspace chat
  3. Go to Search> Expenses> All
  4. Verify there is a green Pay button next to expense
  5. Click on Pay button

Expected Result:

Expense should be payed

Actual Result:

Expense details page is open and expense is not payed/ No Pay button when detailed page is open

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6694571_1734210557354.Recording__4739.mp4
Upwork Automation - Do Not Edit

    @j-piasecki
    Copy link
    Contributor Author

    Expense - Unfunctional Pay button is present on workspace chat expenses in search

    Not reproducible after merging the main branch:

    Screen.Recording.2024-12-16.at.09.51.27.mov

    @lanitochka17
    Copy link

    lanitochka17 commented Dec 16, 2024 •
    edited
    Loading

    If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

    Track - 'Rate not valid for this workspace' error using Categorize it

    Version Number: 9.0.75-0
    Reproducible in staging?: N
    Reproducible in production?: N
    If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
    Issue reported by: Applause - Internal Team

    Action Performed:

    Precondition: user has WS. There is track expense (distance) added in self-DM chat.

    1. Go to self-DM chat
    2. Choose 'Categorize it' option for track expense
    3. Choose any category

    Expected Result:

    No errors on confirmation page. User can submit expense

    Actual Result:

    An error appears on confirmation page. User can't submit expense
    Rate not valid for this workspace. Please select an available rate from the workspace

    Workaround:

    Unknown

    Platforms:

    Which of our officially supported platforms is this issue occurring on?

    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop

    Screenshots/Videos

    Bug6695688_1734360689655.Screen_Recording_2024-12-16_at_4.43.51_PM.mov
    Upwork Automation - Do Not Edit

      @mvtglobally
      Copy link

      Regression is completed

      @j-piasecki
      Copy link
      Contributor Author

      Track - 'Rate not valid for this workspace' error using Categorize it

      Not reproducible after merging the main branch:

      Screen.Recording.2024-12-17.at.10.24.02.mp4

      @github-actions GitHub Actions
      Copy link
      Contributor

      🚧 @mountiny has triggered a test build. You can view the workflow run here.

      @github-actions GitHub Actions
      Copy link
      Contributor

      🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

      Android 🤖 iOS 🍎
      https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51475/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51475/index.html
      Android iOS
      Desktop 💻 Web 🕸️
      ❌ FAILED ❌ https://51475.pr-testing.expensify.com
      The QR code can't be generated, because the Desktop build failed Web

      👀 View the workflow run that generated this build 👀

      @github-actions GitHub Actions
      Copy link
      Contributor

      🚧 @mountiny has triggered a test build. You can view the workflow run here.

      @github-actions GitHub Actions
      Copy link
      Contributor

      🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

      Android 🤖 iOS 🍎
      https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51475/index.html ❌ FAILED ❌
      Android The QR code can't be generated, because the iOS build failed
      Desktop 💻 Web 🕸️
      https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51475/NewExpensify.dmg https://51475.pr-testing.expensify.com
      Desktop Web

      👀 View the workflow run that generated this build 👀

      @github-actions GitHub Actions
      Copy link
      Contributor

      🚧 @mountiny has triggered a test build. You can view the workflow run here.

      @github-actions GitHub Actions
      Copy link
      Contributor

      🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

      Android 🤖 iOS 🍎
      https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51475/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51475/index.html
      Android iOS
      Desktop 💻 Web 🕸️
      https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51475/NewExpensify.dmg https://51475.pr-testing.expensify.com
      Desktop Web

      👀 View the workflow run that generated this build 👀

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers

      @mountiny mountiny Awaiting requested review from mountiny

      @jayeshmangwani jayeshmangwani Awaiting requested review from jayeshmangwani

      At least 1 approving review is required to merge this pull request.

      Assignees

      @j-piasecki j-piasecki

      Labels
      Ready To Build
      Projects
      None yet
      Milestone
      No milestone
      Development

      Successfully merging this pull request may close these issues.
      9 participants
      @j-piasecki @hannojg @jayeshmangwani @mountiny @IuliiaHerets @lanitochka17 @CyberAndrii @mvtglobally @WoLewicki