Fix/10731 auto focus input #51172

christianwen · 2024-10-21T10:55:18Z

Details

Fixed Issues

$ #10731
PROPOSAL: #10731 (comment)

Tests

10731

Go to any chats
Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown
Sent any message
Open edit mode
Verify that the keyboard is shown
Tap on the composer to bring up context menu.
Verify the context menu is shown

50683

Login to an account
Open any chat, notice that the composer is focused.
Press on CTRL + K
Press ESC key to dismissed the 'search modal'
Verify that: Composer is focused after dismissing the modal

50722

Open the Hybrid app/NewDot app and log in as user A
On a secondary device as user B send an IOU to user A
On main device as user A open the chat with user B
Select a different payment option on the IOU preview
Verify that: The page does not flicker when changing a payment option

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-31.at.11.47.30.mov

Android: mWeb Chrome

Screen.Recording.2024-10-31.at.11.43.17.mov

iOS: Native

Screen.Recording.2024-10-31.at.11.49.52.mov

iOS: mWeb Safari

Screen.Recording.2024-10-31.at.11.39.29.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-31.at.11.39.54.mov

MacOS: Desktop

Screen.Recording.2024-10-31.at.11.53.43.mov

christianwen · 2024-10-31T07:57:00Z

Updated change compare to previous PR:

For 50683: The PR works well without any change, maybe after moving to chat search modal, it's fixed

For 50722: This issue happens even on main, you can see the flicker when the keyboard open. It's the bug from keyboardAvoidingView, in case the soft keyboard is hidden, we don't need to enable it.

melvin-bot · 2024-10-31T08:02:30Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-11-11T08:03:49Z

Reviewing today

DylanDylann · 2024-11-12T07:11:02Z

src/components/Composer/implementation/index.tsx

-        if (!textInputRef) {
-            throw new Error('textInputRef is not available. This should never happen and indicates a developer error.');
-        }
+    useImperativeHandle(


@christianwen Is there any new update on this file?

no new update, just moved to the new file

DylanDylann · 2024-11-12T07:15:16Z

@christianwen Could you also please help to merge the latest main?

christianwen · 2024-11-13T08:48:59Z

@DylanDylann I merged main and resolved conflicts

DylanDylann · 2024-11-13T11:37:34Z

@christianwen It is a bit flicker on Safari

Screen.Recording.2024-11-13.at.18.35.39.mov

christianwen · 2024-11-18T08:28:31Z

@DylanDylann

I removed in shouldFocusInputOnScreenFocus in

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 282 in d5e7a5a

    
           (shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction) && !ReportUtils.isTaskReport(report))) &&

since we want to enable autoFocus in every devices.

but it breaks the following logic

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Line 646 in d5e7a5a

    
           if (!((willBlurTextInputOnTapOutside || shouldAutoFocus) && !isNextModalWillOpenRef.current && !modal?.isVisible && isFocused && (!!prevIsModalVisible || !prevIsFocused))) {

Based on this comment

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 643 to 645 in d5e7a5a

    
           // We want to focus or refocus the input when a modal has been closed or the underlying screen is refocused. 
        
           // We avoid doing this on native platforms since the software keyboard popping 
        
           // open creates a jarring and broken UX.

we need to add shouldFocusInputOnScreenFocus again in the above condition

DylanDylann · 2024-11-18T09:42:22Z

@christianwen BUG on safari: when going to the chat, the cursor displays in the middle or in the end of the composer in a moment
Step:

Go to chat A (Don't see the bug)
Back to LHN
Go to chat A (See the Bug)
Back to LHN
Go to chat A (See the Bug)

Screen.Recording.2024-11-18.at.16.39.33.mov

christianwen · 2024-11-20T09:11:05Z

@DylanDylann

The cursor is hidden when the transition is not finished on staging

Screen.Recording.2024-11-20.at.15.56.44.mov

But when the inputMode is none the cursor is not hidden during report transition. I spent time to invest, unfortunately, I didn't find the RCA, so I just hide the cursor same as what happens on staging.

DylanDylann · 2024-11-20T10:45:17Z

@christianwen With your solution, the draft message will not display right after going to the chat

Screen.Recording.2024-11-20.at.17.44.38.mov

DylanDylann · 2024-12-05T10:25:31Z

@christianwen Please try more time

Screen.Recording.2024-12-05.at.17.25.00.mov

DylanDylann · 2024-12-05T10:43:32Z

Flicker on IOS

Go to any chat that have draft message
Edit message
Click X

Screen.Recording.2024-12-05.at.17.40.06.mov

DylanDylann · 2024-12-10T03:39:01Z

@christianwen Kindly bump

christianwen · 2024-12-16T11:06:04Z

@DylanDylann I fixed. Pls check again

DylanDylann · 2024-12-23T07:53:53Z

@christianwen The change looks fine. Could you please merge the latest main?

DylanDylann · 2024-12-23T07:55:12Z

@christianwen For the failed Eslint, could you also fix it?

DylanDylann · 2024-12-23T08:05:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-23.at.16.00.24.mov

Android: mWeb Chrome

Screen.Recording.2024-12-23.at.16.01.18.mov

iOS: Native

Screen.Recording.2024-12-23.at.15.57.07.mov

iOS: mWeb Safari

Screen.Recording.2024-12-23.at.15.59.34.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-23.at.16.01.40.mov

MacOS: Desktop

Screen.Recording.2024-12-23.at.16.02.31.mov

christianwen · 2024-12-23T08:15:33Z

@DylanDylann merged

christianwen · 2024-12-23T08:38:33Z

@DylanDylann I also updated the default value to avoid eslint error

DylanDylann · 2024-12-23T09:06:44Z

Same here: #32711 (comment)

Just a note:
Reassure Performance Tests
As mentioned above

Updated! For the perf issue, we shouldn't mind about it since this test is to compare the number of re-render when users interact with input in baseline (from main) with the current behavior (this PR). In this PR we try to open the keyboard when they focus on the composer -> it takes 2 times to re-render

This PR will change the current behavior on purpose

DylanDylann

LGTM

DylanDylann · 2024-12-23T09:08:26Z

@iwiznia All yours

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

christianwen · 2024-12-24T03:18:27Z

@DylanDylann @iwiznia I updated

iwiznia · 2024-12-24T16:33:34Z

Hmmm performance tests are failing

DylanDylann · 2024-12-24T16:44:11Z

@iwiznia It is intentional as explained here

OSBotify · 2024-12-24T17:36:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

christianwen added 5 commits October 21, 2024 17:50

fix: 10371 auto focus input

1b5c590

refactor

1af3ada

resolve conflict

7f5f2a7

fix bugs flicker

62513ee

remove console

e4823f0

fix ts

f8c1826

christianwen marked this pull request as ready for review October 31, 2024 08:02

christianwen requested a review from a team as a code owner October 31, 2024 08:02

melvin-bot bot requested a review from DylanDylann October 31, 2024 08:02

melvin-bot bot removed the request for review from a team October 31, 2024 08:02

christianwen mentioned this pull request Oct 31, 2024

[HOLD for payment 2024-10-22] [$2000] Android/IOS - Split/request money - Chat composer is focused after IOU request from green plus button #10731

Open

DylanDylann reviewed Nov 12, 2024

View reviewed changes

resolve conflicts

a3544b3

christianwen added 2 commits November 18, 2024 14:42

Merge branch 'main' into fix/10731-auto-focus-input

b241a6a

prevent refocus on closing modal

50965a7

christianwen added 2 commits November 20, 2024 14:34

Merge branch 'main' into fix/10731-auto-focus-input

a19543e

fix cursor flash

8572622

m-natarajan mentioned this pull request Nov 21, 2024

[HOLD for payment 2024-12-16] [$250] The Composer isn't getting focus again after the attachment modal is dismissed #52898

Closed

8 tasks

christianwen added 2 commits November 25, 2024 14:16

Merge branch 'main' into fix/10731-auto-focus-input

0a2f43b

transparent caret safari

6019f64

christianwen added 2 commits December 16, 2024 15:47

resolve conflicts

388b2d9

prevent focus on main composer after close edit composer

0147ded

christianwen added 3 commits December 17, 2024 15:52

lint fix

cb17a34

refactor

e14a576

prettier fix

8b8510b

christianwen force-pushed the fix/10731-auto-focus-input branch from 7c602dc to 8b8510b Compare December 17, 2024 11:18

resolve conflicts

e196852

update default value

5004df1

DylanDylann approved these changes Dec 23, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia December 23, 2024 09:08

iwiznia reviewed Dec 23, 2024

View reviewed changes

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx Outdated Show resolved Hide resolved

update prop description

1954471

iwiznia approved these changes Dec 24, 2024

View reviewed changes

iwiznia merged commit 8819d9c into Expensify:main Dec 24, 2024
15 of 16 checks passed

github-actions bot mentioned this pull request Dec 24, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #54542

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/10731 auto focus input #51172

Fix/10731 auto focus input #51172

christianwen commented Oct 21, 2024 •

edited

Loading

christianwen commented Oct 31, 2024

melvin-bot bot commented Oct 31, 2024

DylanDylann commented Nov 11, 2024

DylanDylann Nov 12, 2024

christianwen Nov 13, 2024

DylanDylann commented Nov 12, 2024

christianwen commented Nov 13, 2024

DylanDylann commented Nov 13, 2024

christianwen commented Nov 18, 2024

DylanDylann commented Nov 18, 2024 •

edited

Loading

christianwen commented Nov 20, 2024

DylanDylann commented Nov 20, 2024

DylanDylann commented Dec 5, 2024 •

edited

Loading

DylanDylann commented Dec 5, 2024

DylanDylann commented Dec 10, 2024

christianwen commented Dec 16, 2024

DylanDylann commented Dec 23, 2024

DylanDylann commented Dec 23, 2024

DylanDylann commented Dec 23, 2024 •

edited

Loading

christianwen commented Dec 23, 2024

christianwen commented Dec 23, 2024

DylanDylann commented Dec 23, 2024

DylanDylann left a comment

DylanDylann commented Dec 23, 2024

christianwen commented Dec 24, 2024

iwiznia commented Dec 24, 2024

DylanDylann commented Dec 24, 2024

OSBotify commented Dec 24, 2024

Fix/10731 auto focus input #51172

Fix/10731 auto focus input #51172

Conversation

christianwen commented Oct 21, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

christianwen commented Oct 31, 2024

melvin-bot bot commented Oct 31, 2024

DylanDylann commented Nov 11, 2024

DylanDylann Nov 12, 2024

Choose a reason for hiding this comment

christianwen Nov 13, 2024

Choose a reason for hiding this comment

DylanDylann commented Nov 12, 2024

christianwen commented Nov 13, 2024

DylanDylann commented Nov 13, 2024

christianwen commented Nov 18, 2024

DylanDylann commented Nov 18, 2024 • edited Loading

christianwen commented Nov 20, 2024

DylanDylann commented Nov 20, 2024

DylanDylann commented Dec 5, 2024 • edited Loading

DylanDylann commented Dec 5, 2024

DylanDylann commented Dec 10, 2024

christianwen commented Dec 16, 2024

DylanDylann commented Dec 23, 2024

DylanDylann commented Dec 23, 2024

DylanDylann commented Dec 23, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

christianwen commented Dec 23, 2024

christianwen commented Dec 23, 2024

DylanDylann commented Dec 23, 2024

DylanDylann left a comment

Choose a reason for hiding this comment

DylanDylann commented Dec 23, 2024

christianwen commented Dec 24, 2024

iwiznia commented Dec 24, 2024

DylanDylann commented Dec 24, 2024

OSBotify commented Dec 24, 2024

christianwen commented Oct 21, 2024 •

edited

Loading

DylanDylann commented Nov 18, 2024 •

edited

Loading

DylanDylann commented Dec 5, 2024 •

edited

Loading

DylanDylann commented Dec 23, 2024 •

edited

Loading