Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA]Use github.event.release.tag_name instead of github.ref_name for releases #47250

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[No QA]Use github.event.release.tag_name instead of github.ref_name for releases #47250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/platformDeploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
- name: Archive Android sourcemaps
uses: actions/upload-artifact@v4
with:
name: android-sourcemap-${{ github.ref_name }}
name: android-sourcemap-${{ github.event.release.tag_name }}
path: android/app/build/generated/sourcemaps/react/productionRelease/index.android.bundle.map

- name: Upload Android build to GitHub artifacts
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
- name: Archive desktop sourcemaps
uses: actions/upload-artifact@v4
with:
name: desktop-sourcemap-${{ github.ref_name }}
name: desktop-sourcemap-${{ github.event.release.tag_name }}
path: desktop/dist/www/merged-source-map.js.map

iOS:
Expand Down Expand Up @@ -260,7 +260,7 @@ jobs:
- name: Archive iOS sourcemaps
uses: actions/upload-artifact@v4
with:
name: ios-sourcemap-${{ github.ref_name }}
name: ios-sourcemap-${{ github.event.release.tag_name }}
path: main.jsbundle.map

- name: Upload iOS build to GitHub artifacts
Expand Down Expand Up @@ -353,7 +353,7 @@ jobs:
- name: Archive web sourcemaps
uses: actions/upload-artifact@v4
with:
name: web-sourcemap-${{ github.ref_name }}
name: web-sourcemap-${{ github.event.release.tag_name }}
path: dist/merged-source-map.js.map

- name: Purge Cloudflare cache
Expand All @@ -365,7 +365,7 @@ jobs:
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
run: |
DOWNLOADED_VERSION="$(wget -q -O /dev/stdout https://staging.new.expensify.com/version.json | jq -r '.version')"
if [[ '${{ github.ref_name }}' != "$DOWNLOADED_VERSION" ]]; then
if [[ '${{ github.event.release.tag_name }}' != "$DOWNLOADED_VERSION" ]]; then
echo "Error: deployed version does not match local version. Something went wrong..."
exit 1
fi
Expand Down
Loading