Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Perf:
PlatormStackNavigation
- Use@react-navigation/native-stack
on mobile platforms #37891[NoQA] Perf:
PlatormStackNavigation
- Use@react-navigation/native-stack
on mobile platforms #37891Changes from 207 commits
7628767
349e3b0
afcb123
90c03a7
047ea38
b5e5e7d
9664f2b
8860266
afde8de
07fb94f
6b6690c
b9d2262
2aec5af
3bc8265
f2c32e6
2fff6cb
ffa510b
651bbef
915bafc
6729764
ea5172c
5ca7316
a0be472
5282af1
3121e45
3b9b5b0
57bfdd2
a9dbb9e
85fc4bb
75b5cac
1c60ee6
1f78767
c5b5775
23b70c2
a47a398
289ba71
18fc893
3b40ab2
0dbc9a7
b3ec7ef
7ec5d05
8c4df3a
f33eba6
884627b
568cf4a
eda54ab
de68a31
f8dc036
e6aae18
86a3af7
69a534c
9296237
346f4e6
8744c4b
210a95f
96cd874
b4f3248
5e453ba
6e8a07d
57a3250
f937f54
5acaa45
a346076
256ee99
c9c2008
15b7689
48632e7
6327d66
1080e07
6649b86
be6b3ed
32cfce4
9f592f3
850bb3d
706dc61
10e50c2
26a667a
1620f0c
43f7848
2fe3e72
85d015e
00fa244
6d25042
56d210f
0dcb55e
8875023
4b40806
a2f16c3
b322da4
451ce65
ed39726
929c655
899f180
549d0f1
5a35435
22c0e16
d78c8ed
8ba4ccc
316d44f
8a4524c
09a39b9
3f094af
7c04f3f
26bc827
bd961fa
d64570d
4292e59
552b978
3d37d9d
c443b1c
fb718b7
5cf5c71
1e61de8
935e673
36d426b
6076420
4142883
f6faabd
3e1e8ca
2b741ff
d068e77
87a9884
3d068bc
4b04c4a
70a6d48
bea66c0
91ee836
041262a
7129a3c
239e6ea
2968c26
cc81448
9aadd77
ac34ed9
94c6ec2
2442679
5258724
7684407
625a00b
1a992c7
f132d9c
b97e15a
30b5e48
05e7be0
9927faf
af97d99
a4effeb
1e4f480
fcb9849
63c9f94
3ebddd8
1dae4dd
a07e571
9c85763
e0a9fc0
ed0c177
1bd5a6a
ecd8b53
e4be7cf
24287b5
2fa23e3
5b1e5fb
a404e55
3ea4cdd
296afc1
d5e7497
b37e0a2
8d50c0c
8f1dc94
d3c33c4
0527250
b90ba70
75c40fb
6db8b60
0e9cbfd
234e91e
b7155b1
c4639ab
3f4280d
88cbda4
7d7823d
fb5a17d
ce4f8c6
5701c46
c3c7c7a
c2062c6
4f50477
e3f4372
78de04c
cb2687a
300922a
225194a
f32a857
525325b
107e5c5
d416c6e
1d51dbf
e989200
d880c39
ec2cbe9
e012a79
922d145
fffd74d
064ad5b
0ade1e1
3325a07
6c22124
bf06916
3bc381c
707e207
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is possible to put
/w/${activeWorkspaceID}/${ROUTES.HOME}
on ROUTES.ts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabioh8010 again, I think it's copied/pasted code, so not sure if we need to do that 🙈
And additionally - is it possible to create dynamic routes in
ROUTES.ts
? Or we want to add two routes and use ternary operator inBottomTabBar.tsx
and choose between two routes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answered here