keeps highlighted the preferred skinton emoji #12860

Pujan92 · 2022-11-18T10:40:24Z

Details

keeps highlighted the preferred skinton emoji

Fixed Issues

$ #12804
PROPOSAL: #12804 (comment)

Tests

Open emoji list modal
Click on the Change default skintone
Preferred skintone should be highlighted

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open emoji list modal
Click on the Change default skintone
Preferred skintone should be highlighted

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

54bc2167-00c4-4e88-86d9-b22cb63850b5.webm

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2022-11-18.at.4.08.49.PM.mov

iOS

Android

melvin-bot · 2022-11-18T10:40:54Z

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dangrous · 2022-11-18T17:06:59Z

@francoisl and @rushatgabhane I think this is for an issue you're both assigned to. I unassigned myself but I'm happy to stick around as another pair of eyes though if you want me to.

rushatgabhane · 2022-11-18T17:24:27Z

@Pujan92 please add screenshots for all platforms

Pujan92 · 2022-11-18T18:14:54Z

@Pujan92 please add screenshots for all platforms

@rushatgabhane Added!

francoisl · 2022-11-18T22:01:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-11-18.at.10.13.01.AM.mov

Mobile Web - Chrome

Screen.Recording.2022-11-18.at.10.35.13.AM.mov

Mobile Web - Safari

Screen.Recording.2022-11-18.at.10.21.04.AM.mov

Desktop

Screen.Recording.2022-11-18.at.10.15.59.AM.mov

iOS

(Note that I'm "pressing long" on purpose to show that the new preferred skin tone is highlighted when you press. There is no delay if you press and release)

Screen.Recording.2022-11-18.at.10.24.13.AM.mov

Android

Screen.Recording.2022-11-18.at.10.31.38.AM.mov

rushatgabhane

LGTM as well!

PR review checklist

Screenshots/Videos

Web

Screen.Recording.2022-11-21.at.2.01.35.PM.mov

Mobile Web - Chrome

Screen.Recording.2022-11-21.at.2.05.41.PM.mov

Mobile Web - Safari

Screen.Recording.2022-11-21.at.2.03.12.PM.mov

Android

Desktop

Screen.Recording.2022-11-21.at.2.08.11.PM.mov

iOS

Screen.Recording.2022-11-21.at.2.10.52.PM.mov

melvin-bot · 2022-11-21T18:03:54Z

@francoisl looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

francoisl · 2022-11-21T18:07:48Z

Not an emergency, the author checklist was complete.

OSBotify · 2022-11-21T18:08:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-22T16:36:23Z

🚀 Deployed to staging by @francoisl in version: 1.2.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-22T17:46:08Z

🚀 Deployed to staging by @francoisl in version: 1.2.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-11-24T00:04:30Z

🚀 Deployed to production by @luacmartins in version: 1.2.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rayane-djouah · 2024-12-13T10:37:34Z

src/components/EmojiPicker/EmojiSkinToneList.js

-                                        isHighlighted={skinToneEmoji.skinTone === this.state.highlightedIndex}
+                                        isHighlighted={skinToneEmoji.skinTone === this.state.highlightedIndex || skinToneEmoji.skinTone === selectedEmoji.skinTone}


FYI, this caused the following issue: #52918
We need to make sure that state.highlightedIndex is updated when the selectedEmoji.skinTone is changed, otherwise, two emoji skin tones will be highlighted at the same time.
More details can be found in this proposal: #52918 (comment)

keeps highlighted preffered skinton emoji

56be49a

Pujan92 requested a review from a team as a code owner November 18, 2022 10:40

melvin-bot bot requested review from dangrous and removed request for a team November 18, 2022 10:40

dangrous requested review from rushatgabhane and francoisl and removed request for dangrous November 18, 2022 17:06

francoisl approved these changes Nov 18, 2022

View reviewed changes

rushatgabhane approved these changes Nov 21, 2022

View reviewed changes

francoisl merged commit 649a047 into Expensify:main Nov 21, 2022

melvin-bot bot added the Emergency label Nov 21, 2022

francoisl removed the Emergency label Nov 21, 2022

OSBotify mentioned this pull request Nov 22, 2022

Deploy Checklist: New Expensify 2022-11-22 #12934

Closed

40 tasks

rayane-djouah reviewed Dec 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

keeps highlighted the preferred skinton emoji #12860

keeps highlighted the preferred skinton emoji #12860

Pujan92 commented Nov 18, 2022 •

edited by francoisl

Loading

melvin-bot bot commented Nov 18, 2022

dangrous commented Nov 18, 2022

rushatgabhane commented Nov 18, 2022

Pujan92 commented Nov 18, 2022

francoisl commented Nov 18, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

melvin-bot bot commented Nov 21, 2022

francoisl commented Nov 21, 2022

OSBotify commented Nov 21, 2022

OSBotify commented Nov 22, 2022

OSBotify commented Nov 22, 2022

OSBotify commented Nov 24, 2022

rayane-djouah Dec 13, 2024

		isHighlighted={skinToneEmoji.skinTone === this.state.highlightedIndex}
		isHighlighted={skinToneEmoji.skinTone === this.state.highlightedIndex \|\| skinToneEmoji.skinTone === selectedEmoji.skinTone}

keeps highlighted the preferred skinton emoji #12860

keeps highlighted the preferred skinton emoji #12860

Conversation

Pujan92 commented Nov 18, 2022 • edited by francoisl Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot bot commented Nov 18, 2022

dangrous commented Nov 18, 2022

rushatgabhane commented Nov 18, 2022

Pujan92 commented Nov 18, 2022

francoisl commented Nov 18, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

melvin-bot bot commented Nov 21, 2022

francoisl commented Nov 21, 2022

OSBotify commented Nov 21, 2022

OSBotify commented Nov 22, 2022

OSBotify commented Nov 22, 2022

OSBotify commented Nov 24, 2022

rayane-djouah Dec 13, 2024

Choose a reason for hiding this comment

Pujan92 commented Nov 18, 2022 •

edited by francoisl

Loading

francoisl commented Nov 18, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading