Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-15] "No Accounts" Page for Unsupported Card-Level Export Options #54371

Open
1 of 8 tasks
m-natarajan opened this issue Dec 19, 2024 · 13 comments
Open
1 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Dec 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): expense

Action Performed:

  1. Set non-reimbursable exports to something that supports card-level export settings (like QBO credit cards). go to the card details page of an assign card.
  2. Click the card export row.
  3. Click the link in the subheader to go to the accounting integration settings.
  4. Change the non-reimbursable exports to something that doesn't support card-level export settings (like QBO vendor bills).
  5. Click back couple of times.

Expected Result:

When going back, land directly on the card details page with no export option

Actual Result:

No Accounts page displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
2024-12-18_13-57-13.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Christinadobrzyn
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 19, 2024
Copy link

melvin-bot bot commented Dec 19, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dukenv0307
Copy link
Contributor

@Christinadobrzyn I'm working on card project so I can help take it as C+

@Christinadobrzyn
Copy link
Contributor

Thanks @dukenv0307! @dukenv0307 @mountiny I assume this is an internal project?

@Christinadobrzyn Christinadobrzyn added the Internal Requires API changes or must be handled by Expensify staff label Dec 19, 2024
@mountiny
Copy link
Contributor

@waterim or @narefyev91 might take it

@narefyev91
Copy link
Contributor

Hi, I’m Nicolay from Callstack and I would like to investigate this issue.

@Christinadobrzyn
Copy link
Contributor

Just a heads up that I'm going to be ooo until Dec 30th. I'm not going to assign this to a BZ teammate but if anything is urgent, please reach out to the team for a volunteer.

Copy link

melvin-bot bot commented Dec 30, 2024

@narefyev91, @mountiny, @Christinadobrzyn, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jan 1, 2025

@narefyev91, @mountiny, @Christinadobrzyn, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

@Christinadobrzyn
Copy link
Contributor

I think callstack is back in the office on Monday so we'll move this forward then

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Jan 3, 2025
@melvin-bot melvin-bot bot changed the title "No Accounts" Page for Unsupported Card-Level Export Options [HOLD for payment 2025-01-15] "No Accounts" Page for Unsupported Card-Level Export Options Jan 8, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 8, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-15. 🎊

For reference, here are some details about the assignees on this issue:

  • @narefyev91 does not require payment (Contractor)
  • @dukenv0307 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jan 8, 2025

@dukenv0307 @Christinadobrzyn @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@dukenv0307
Copy link
Contributor

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment:

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template
  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Test:

  1. Set non-reimbursable exports to something that supports card-level export settings (like QBO credit cards). go to the card details page of an assign card.
  2. Click the card export row.
  3. Click the link in the subheader to go to the accounting integration settings.
  4. Change the non-reimbursable exports to something that doesn't support card-level export settings (like QBO vendor bills).
  5. Click back couple of times.
  6. Verify that user lands directly to card details page
  7. Verify that Export menu item is not shown

Do we agree 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

5 participants