fix: Make all task titles/descriptions read-only to all but the author/assignee.

[Krishna2323]

Explanation of Change

Fixed Issues

$ #52979
PROPOSAL: #52979 (comment)

Tests

1. [Account A]: Create a new account > complete onboarding and open Concierge chat.
2. [Account A]: Try to complete the assigned tasks from the preview (should not open the task before doing this step)
3. [Account A]: Verify task can be completed/incomplete from the task preview checkbox
4. [Account A]: Open any task > Verify you cannot open task title, description and assignee page.
5. [Account A]: Verify you can still complete the task using the checkbox
6. [Account B]: Create a new task (without assignee) in the chat of Account A.
7. [Account A]: Verify you cannot edit task title, description and assignee page and task status (complete/incomplete)
8. [Account B]: Assign the task to Account A
9. [Account A]: Verify you cannot edit task title, description and assignee page and but can updated task status (complete/incomplete)

• Verify that no errors appear in the JS console

Offline tests

1. [Account A]: Create a new account > complete onboarding and open Concierge chat.
2. [Account A]: Try to complete the assigned tasks from the preview (should not open the task before doing this step)
3. [Account A]: Verify task can be completed/incomplete from the task preview checkbox
4. [Account A]: Open any task > Verify you cannot open task title, description and assignee page.
5. [Account A]: Verify you can still complete the task using the checkbox
6. [Account B]: Create a new task (without assignee) in the chat of Account A.
7. [Account A]: Verify you cannot edit task title, description and assignee page and task status (complete/incomplete)
8. [Account B]: Assign the task to Account A
9. [Account A]: Verify you cannot edit task title, description and assignee page and but can updated task status (complete/incomplete)

QA Steps

1. [Account A]: Create a new account > complete onboarding and open Concierge chat.
2. [Account A]: Try to complete the assigned tasks from the preview (should not open the task before doing this step)
3. [Account A]: Verify task can be completed/incomplete from the task preview checkbox
4. [Account A]: Open any task > Verify you cannot open task title, description and assignee page.
5. [Account A]: Verify you can still complete the task using the checkbox
6. [Account B]: Create a new task (without assignee) in the chat of Account A.
7. [Account A]: Verify you cannot edit task title, description and assignee page and task status (complete/incomplete)
8. [Account B]: Assign the task to Account A
9. [Account A]: Verify you cannot edit task title, description and assignee page and but can updated task status (complete/incomplete)

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

[melvin-bot]

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Krishna2323]

@Expensify/design @thienlnam, before recording the videos, I want to confirm if the disabled cursor looks correct or not. I feel it might confuse users, making them think they can't click the link (which we want them to click).

Context: When users accidentally edit the description of a task assigned to them, it unexpected and feels broken, undermining the perception of product quality and conversion. So we decided to disable editing the task fields if the task created by Concierge, users will be only able to complete/incomplete the tasks.

Monosnap.screencast.2024-12-09.16-18-14.mp4

[Krishna2323]

@shawnborton @dubielzyk-expensify @dannymcclain, could you please check the comment above🙏🏻? I think Expensify/design tag isn't working?

[dannymcclain]

We don't need to use the not-allowed cursor. Just not having the right caret and not being able to click in to edit is enough.

Check out this screenshot from an expense. I can no longer change the merchant or date, but I can still change the description, category, and tag. My cursor is totally normal when I hover over the merchant and date rows, they just don't do anything.

[dannymcclain]

Just realized a video would probably be more clear:

CleanShot.2024-12-10.at.08.25.27.mp4

[shawnborton]

Just not having the right caret and not being able to click in to edit is enough.

Totally agree with that. Your video is exactly what we want to happen with tasks.

[dubielzyk-expensify]

Agree with the designers 👍

[Krishna2323]

@Expensify/design, does this look correct now?

Monosnap.screencast.2024-12-11.09-49-29.mp4

[dubielzyk-expensify]

Looks right to me 👍

[dannymcclain]

Yeah that looks right to me too 👍

[shawnborton]

Yup, looks good to me three!

[Krishna2323]

Thanks for the confirmation, I will add the recordings today.

[Krishna2323]

@Expensify/design, please review the behaviour new behaviour below and let me know if I'm still missing something. Thanks!

Monosnap.screencast.2024-12-17.05-17-42.mp4

[dubielzyk-expensify]

That looks right to me. Gut check from @Expensify/design

[shawnborton]

Yup, looks good to me too!

[dannymcclain]

Just so I'm totally understanding: have we updated the tasks so that only the author or the person assigned can complete/uncomplete the task? Just wanted to double-check that behavior, other than that, it looks good to me too.

[shawnborton]

have we updated the tasks so that only the author or the person assigned can complete/uncomplete the task?

I don't know if we updated anything there? My understanding is that we didn't touch that part of the task UX. Basically if you have access to view a task (aka if the message/thread was shared with you), you have access to complete or uncomplete it. I think that's how it's always been though?

[dannymcclain]

Just looking at this part of the video (around 1:28) and seeing the checkbox and mark as complete button disabled. So I'm trying to figure out under what conditions those things would be disabled.

[shawnborton]

Ah, great catch on that - @Krishna2323 what are your thoughts there?

[Krishna2323]

My understanding is that we didn't touch that part of the task UX.

Correct, we haven't changed that implementation.

Basically if you have access to view a task (aka if the message/thread was shared with you), you have access to complete or uncomplete it. I think that's how it's always been though?

Nope, task can be only marked as complete/incomplete only by the author and assignee.

[shawnborton]

Okay cool, as long as we aren't changing anything about that behavior then we're all good 👍

[Krishna2323]

@suneox, you can start reviewing again, I will update the test steps and recording today.

[suneox]

@suneox, you can start reviewing again, I will update the test steps and recording today.

Sure I'll review pr again within a few hours

[suneox]

@suneox, you can start reviewing again, I will update the test steps and recording today.

@Krishna2323 The changes look good; please proceed to update ESLint.

[suneox]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-12-22.at.23.25.35.mp4

MacOS: Desktop

Screen.Recording.2024-12-22.at.23.28.36.mp4

Android: Native

Screen.Recording.2024-12-22.at.23.37.50.mp4

Android: mWeb Chrome

Screen.Recording.2024-12-22.at.23.36.31.mp4

iOS: Native

Screen.Recording.2024-12-22.at.23.32.59.mp4

iOS: mWeb Safari

Screen.Recording.2024-12-22.at.23.34.16.mp4

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	cancelled 🔪
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

[github-actions]

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.78-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.78-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅