[HOLD] Keep navigation within the RHP when navigating from a report to an expense on the Search page

[shawnborton]

Background: Users often utilize the Search page to find and access reports through the Right-Hand Pane (RHP). The RHP allows them to view reports without leaving the Search page, providing a seamless and efficient experience.

Problem: When users attempt to view an expense from a report opened in the RHP, they are redirected to the Inbox, disrupting their workflow and preventing them from maintaining their original context.

Solution: Adjust the RHP navigation stack in Search so that any content accessed from within the RHP remains within it. This change will enable users to navigate from a report to its associated expenses entirely within the RHP, allowing for smooth, uninterrupted exploration of report details without leaving the Search page.

Screen.Recording.2024-11-21.at.14.28.34.mov

[shawnborton]

cc @adamgrzybowski @Kicu @WojtekBoman

[melvin-bot]

@shawnborton, @luacmartins, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Kicu]

This is being actively worked on

[shawnborton]

Not overdue, SWM is working on it.

[JmillsExpensify]

Btw, what's the difference between this issue and this one?

[shawnborton]

Good question, thoughts @luacmartins ?

[luacmartins]

They are the same. I'll close the other issue in favor of this one, since it has a more structured P/S

[trjExpensify]

Coupla' things:

• We are going to keep this moving forward, yes?
• I'm moving this project into #migrate to track along with this next wave of changes.

[luacmartins]

@trjExpensify @shawnborton can you share what the new navigation flows should be in the Search page? That'd give us a better idea if this is still needed or not

[JmillsExpensify]

What do you mean by new navigation flows?

[trjExpensify]

The redesign, report in the main pane etc.

[luacmartins]

Basically what navigating from an expense/report row to a report in the main pane to an expense in the RHP then clicking any link in the RHP, etc

[mountiny]

Native stack PR merged and getting through the follow up bugs, this will unblock the bottom tab refactor and these changes too

[shawnborton]

Hey there - sorry for the delay!

The general idea that we're toying around with is that you could potentially open up a report directly from the Search page, which might give us something like this:

The if you click on an expense on the report, we would open it up in the RHP:

I don't know what we should do about navigating from a report in Search to the workspace chat... part of me thinks if you click on the small link in the header here:

...that we would take you to the actual workspace chat over in the Inbox page? I'm not too sure really.

That being said, I do think it makes sense to keep the user in the RHP if they are navigating into a thread inside of an expense or something like that. Curious what you think though and how those potential changes might impact this particular GH issue.

[luacmartins]

That being said, I do think it makes sense to keep the user in the RHP if they are navigating into a thread inside of an expense or something like that.

So we'd keep the user in the RHP if they clicked any link in the RHP chat?

[shawnborton]

I wouldn't say "any link" but we'd want to keep them in the RHP if they were drilling down into a thread or something.

It gets a bit tricky though because in theory, you could first open up an expense in the RHP from the Search > All page. But then from the expense, you could go up a level and view the report. Maybe it's okay to keep that report in the RHP, but then we have a consistency where sometimes the report can be opened in the main content pane and sometimes it can be opened up in the RHP.

I think the best path forward might just be to try to keep the user in the RHP if they are navigating around within the RHP in relation to workspace chat/report/expense views.

[shawnborton]

Going to throw a HOLD on this one while we sort out some of the high-level discussions around Search V3. Sorry for the change of plans, but let's make sure we attack this one with alignment.

[shawnborton]

Still holding