Skip to content

Commit

Permalink
remove some useless comment
Browse files Browse the repository at this point in the history
  • Loading branch information
nkdengineer committed Dec 23, 2024
1 parent ab6727a commit f6c5759
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion src/ONYXKEYS.ts
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,6 @@ type OnyxValuesMapping = {
[ONYXKEYS.ACCOUNT_MANAGER_REPORT_ID]: string;
[ONYXKEYS.NVP_IS_FIRST_TIME_NEW_EXPENSIFY_USER]: boolean;

// NVP_ONBOARDING is an array for old users.
[ONYXKEYS.NVP_ONBOARDING]: Onboarding;

// ONYXKEYS.NVP_TRYNEWDOT is HybridApp onboarding data
Expand Down
2 changes: 1 addition & 1 deletion src/libs/ReportUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8354,7 +8354,7 @@ function shouldShowMerchantColumn(transactions: Transaction[]) {
* only use the Concierge chat.
*/
function isChatUsedForOnboarding(optionOrReport: OnyxEntry<Report> | OptionData): boolean {
// onboarding can be an array or an empty object for old accounts and accounts created from olddot
// onboarding can be an empty object for old accounts and accounts created from olddot
if (onboarding && !isEmptyObject(onboarding) && onboarding.chatReportID) {
return onboarding.chatReportID === optionOrReport?.reportID;
}
Expand Down
1 change: 0 additions & 1 deletion tests/unit/OnboardingSelectorsTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ describe('onboardingSelectors', () => {
// Not all users have this NVP defined as we did not run a migration to backfill it for existing accounts, hence we need to make sure
// the onboarding flow is only showed to the users with `hasCompletedGuidedSetupFlow` set to false
describe('hasCompletedGuidedSetupFlowSelector', () => {
// It might be the case that backend returns an empty array if the NVP is not defined on this particular account
it('Should return true if onboarding NVP is an empty object', () => {
const onboarding = {} as OnyxValue<typeof ONYXKEYS.NVP_ONBOARDING>;
expect(hasCompletedGuidedSetupFlowSelector(onboarding)).toBe(true);
Expand Down

0 comments on commit f6c5759

Please sign in to comment.