Merge pull request #52793 from Expensify/revert-52694-loading-skeleto…

…n-when-notification-tapped-ND (cherry picked from commit b4830af) (CP triggered by mountiny)
Expensify · Nov 20, 2024 · 8e5d586 · 8e5d586
1 parent aee19a2
commit 8e5d586
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 18 deletions.
diff --git a/src/components/InitialURLContextProvider.tsx b/src/components/InitialURLContextProvider.tsx
@@ -1,10 +1,8 @@
 import React, {createContext, useEffect, useMemo, useState} from 'react';
 import type {ReactNode} from 'react';
 import {Linking} from 'react-native';
-import {useOnyx} from 'react-native-onyx';
 import {signInAfterTransitionFromOldDot} from '@libs/actions/Session';
 import CONST from '@src/CONST';
-import ONYXKEYS from '@src/ONYXKEYS';
 import type {Route} from '@src/ROUTES';
 import {useSplashScreenStateContext} from '@src/SplashScreenStateContext';
 
@@ -30,13 +28,10 @@ type InitialURLContextProviderProps = {
 function InitialURLContextProvider({children, url}: InitialURLContextProviderProps) {
     const [initialURL, setInitialURL] = useState<Route | undefined>();
     const {setSplashScreenState} = useSplashScreenStateContext();
-    const [initialLastUpdateIDAppliedToClient, metadata] = useOnyx(ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT);
+
     useEffect(() => {
-        if (metadata.status !== 'loaded') {
-            return;
-        }
         if (url) {
-            signInAfterTransitionFromOldDot(url, initialLastUpdateIDAppliedToClient).then((route) => {
+            signInAfterTransitionFromOldDot(url).then((route) => {
                 setInitialURL(route);
                 setSplashScreenState(CONST.BOOT_SPLASH_STATE.READY_TO_BE_HIDDEN);
             });
@@ -45,7 +40,7 @@ function InitialURLContextProvider({children, url}: InitialURLContextProviderPro
         Linking.getInitialURL().then((initURL) => {
             setInitialURL(initURL as Route);
         });
-    }, [initialLastUpdateIDAppliedToClient, metadata.status, setSplashScreenState, url]);
+    }, [setSplashScreenState, url]);
 
     const initialUrlContext = useMemo(
         () => ({
@@ -61,5 +56,4 @@ function InitialURLContextProvider({children, url}: InitialURLContextProviderPro
 InitialURLContextProvider.displayName = 'InitialURLContextProvider';
 
 export default InitialURLContextProvider;
-
 export {InitialURLContext};
diff --git a/src/libs/actions/Session/index.ts b/src/libs/actions/Session/index.ts
@@ -481,7 +481,7 @@ function signUpUser() {
     API.write(WRITE_COMMANDS.SIGN_UP_USER, params, {optimisticData, successData, failureData});
 }
 
-function signInAfterTransitionFromOldDot(transitionURL: string, lastUpdateId?: number) {
+function signInAfterTransitionFromOldDot(transitionURL: string) {
     const [route, queryParams] = transitionURL.split('?');
 
     const {
@@ -528,14 +528,7 @@ function signInAfterTransitionFromOldDot(transitionURL: string, lastUpdateId?: n
                     [ONYXKEYS.NVP_TRYNEWDOT]: {classicRedirect: {completedHybridAppOnboarding: completedHybridAppOnboarding === 'true'}},
                 }),
             )
-            .then(() => {
-                if (clearOnyxOnStart === 'true') {
-                    // We clear Onyx when this flag is set to true so we have to download all data
-                    App.openApp();
-                } else {
-                    App.reconnectApp(lastUpdateId);
-                }
-            })
+            .then(App.openApp)
             .catch((error) => {
                 Log.hmmm('[HybridApp] Initialization of HybridApp has failed. Forcing transition', {error});
             })