fix: NetSuite - 'Select existing' invoice item option isn't highlight…

…ed when selected. Signed-off-by: krishna2323 <[email protected]>
Expensify · Aug 9, 2024 · 6cf1f41 · 6cf1f41
1 parent 31c301e
commit 6cf1f41
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/components/SelectionList/BaseSelectionList.tsx b/src/components/SelectionList/BaseSelectionList.tsx
@@ -450,7 +450,7 @@ function BaseSelectionList<TItem extends ListItem>(
                         if (shouldSingleExecuteRowSelect) {
                             singleExecution(() => selectRow(item, index))();
                         } else {
-                            selectRow(item);
+                            selectRow(item, index);
                         }
                     }}
                     onCheckboxPress={handleOnCheckboxPress()}

diff --git a/src/components/SelectionScreen.tsx b/src/components/SelectionScreen.tsx
@@ -90,6 +90,9 @@ type SelectionScreenProps<T = string> = {
 
     /** Used for dynamic header title translation with parameters */
     headerTitleAlreadyTranslated?: string;
+
+    /** Whether to update the focused index on a row select */
+    shouldUpdateFocusedIndex?: boolean;
 };
 
 function SelectionScreen<T = string>({
@@ -114,6 +117,7 @@ function SelectionScreen<T = string>({
     onClose,
     shouldSingleExecuteRowSelect,
     headerTitleAlreadyTranslated,
+    shouldUpdateFocusedIndex = false,
 }: SelectionScreenProps<T>) {
     const {translate} = useLocalize();
     const styles = useThemeStyles();
@@ -153,6 +157,7 @@ function SelectionScreen<T = string>({
                         listFooterContent={listFooterContent}
                         sectionListStyle={[styles.flexGrow0]}
                         shouldSingleExecuteRowSelect={shouldSingleExecuteRowSelect}
+                        shouldUpdateFocusedIndex={shouldUpdateFocusedIndex}
                     >
                         <ErrorMessageRow
                             errors={errors}

diff --git a/src/pages/workspace/accounting/netsuite/export/NetSuiteInvoiceItemSelectPage.tsx b/src/pages/workspace/accounting/netsuite/export/NetSuiteInvoiceItemSelectPage.tsx
@@ -65,6 +65,7 @@ function NetSuiteInvoiceItemSelectPage({policy}: WithPolicyConnectionsProps) {
             listEmptyContent={listEmptyContent}
             connectionName={CONST.POLICY.CONNECTIONS.NAME.NETSUITE}
             shouldBeBlocked={config?.invoiceItemPreference !== CONST.NETSUITE_INVOICE_ITEM_PREFERENCE.SELECT}
+            shouldUpdateFocusedIndex
         />
     );
 }