Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cars enhancements #29

Merged
merged 4 commits into from
Nov 19, 2024
Merged

feat: cars enhancements #29

merged 4 commits into from
Nov 19, 2024

Conversation

anssari1
Copy link
Contributor

@anssari1 anssari1 commented Nov 19, 2024 •
edited
Loading

Situation

Improve experience of SDK users by updating the datatypes of requests parameters to be more suitable for what they represent

Task

  • Pickup/drop-off times are optional strings. Convert them to date-time with hours/minutes
  • Pickup/drop-off radii are strings. Convert them to integer

Action

  • Update specs
  • Add pickup/drop-off time post-processors to truncate LocalDateTime value

Testing

Updated examples in a separate PR

Results

Better user experience with more intuitive datatypes for request params

Notes

@anssari1 anssari1 marked this pull request as ready for review November 19, 2024 09:28
@anssari1 anssari1 requested a review from a team as a code owner November 19, 2024 09:28
@anssari1 anssari1 changed the title feat: feat: cars enhancements Nov 19, 2024
@anssari1 anssari1 merged commit 372aa90 into main Nov 19, 2024
5 checks passed
@anssari1 anssari1 deleted the nanssari/cars_updates branch November 19, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtayeh dtayeh dtayeh approved these changes

@mohnoor94 mohnoor94 mohnoor94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anssari1 @mohnoor94 @dtayeh