removing shutdown (always throws an exception) and fix log

ExpediaGroup · Nov 27, 2023 · 55cb714 · 55cb714
1 parent a967527
commit 55cb714
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/...ce-core/src/main/java/com/hotels/bdp/waggledance/client/ThriftMetastoreClientManager.java b/...ce-core/src/main/java/com/hotels/bdp/waggledance/client/ThriftMetastoreClientManager.java
@@ -246,15 +246,6 @@ public void close() {
       return;
     }
     isConnected = false;
-    try {
-      if (client != null) {
-        client.shutdown();
-      }
-    } catch (TException e) {
-      LOG.debug("Unable to shutdown metastore client. Will try closing transport directly.", e);
-    }
-    // Transport would have got closed via client.shutdown(), so we don't need this, but
-    // just in case, we make this call.
     if ((transport != null) && transport.isOpen()) {
       transport.close();
       transport = null;

diff --git a/...s/bdp/waggledance/client/compatibility/HiveCompatibleThriftHiveMetastoreIfaceFactory.java b/...s/bdp/waggledance/client/compatibility/HiveCompatibleThriftHiveMetastoreIfaceFactory.java
@@ -66,8 +66,8 @@ public Object invoke(Object proxy, Method method, Object[] args) throws Throwabl
         } catch (Throwable t) {
           log
               .warn(
-                  "Unable to invoke compatibility for metastore client method {}. Will rethrow original exception, logging exception from invocation handler",
-                  method.getName(), t);
+                  "Unable to invoke compatibility for metastore client method "+method.getName()+". Will rethrow original exception, logging exception from invocation handler",
+                   t);
         }
         throw delegateException.getCause();
       }