Add a apiary_logs_retention_days variable that sets the retention_day… #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s of the apiary cloudwatch log group. The default is 30 days.
rpoluri
reviewed
May 7, 2020
CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [6.1.2] - TBD | |||
| ### Added | |||
| - Added apiary_logs_retention_days variable that sets the default retention period of the apiary cloudwatch group. The default is 30 days. | |||
There was a problem hiding this comment.
should we name the variable apiary_cloudwatch_logs_retention_days? to avoid confusion with s3 logs retention
There was a problem hiding this comment.
ok, makes sense. updating.
There was a problem hiding this comment.
Does the same apply here? ExpediaGroup/apiary-federation#75 (review)
There was a problem hiding this comment.
I can't say. For me adding cloudwatch in the name only makes sense for apiary-data-lake but you may want to make variable names consistent accross the different components.
barnharts4
reviewed
May 7, 2020
There was a problem hiding this comment.
Agree with @rpoluri about the name of the variable. Elsewhere through the code, "logs" refers to s3 logs.
Otherwise looks good.
barnharts4
previously approved these changes
May 11, 2020
massdosage
suggested changes
May 11, 2020
CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [6.1.2] - TBD | |||
| ### Added | |||
| - Added apiary_cloudwatch_logs_retention_days variable that sets the default retention period of the apiary cloudwatch group. The default is 30 days. | |||
There was a problem hiding this comment.
Suggested change
| - Added apiary_cloudwatch_logs_retention_days variable that sets the default retention period of the apiary cloudwatch group. The default is 30 days. | |
| - Added `apiary_cloudwatch_logs_retention_days` variable that sets the default retention period of the Apiary CloudWatch group. The default is 30 days. |
CHANGELOG.md
Outdated
| @@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [6.1.2] - TBD | |||
There was a problem hiding this comment.
Could go with 6.2.0 as this is a new feature rather than a bugfix.
VARIABLES.md
Outdated
| @@ -10,6 +10,7 @@ | |||
| | apiary_domain_name | Apiary domain name for Route 53. | string | `` | no | | |||
| | apiary_log_bucket | Bucket for Apiary logs. | string | - | yes | | |||
| | apiary_log_prefix | Prefix for Apiary logs. | string | `` | no | | |||
| | apiary_cloudwatch_logs_retention_days | Log retention in days for the Apiary ECS cloudwatch log group. | string | `30` | no | | |||
There was a problem hiding this comment.
Suggested change
| | apiary_cloudwatch_logs_retention_days | Log retention in days for the Apiary ECS cloudwatch log group. | string | `30` | no | | |
| | apiary_cloudwatch_logs_retention_days | Log retention in days for the Apiary ECS CloudWatch log group. | string | `30` | no | |
variables.tf
Outdated
| @@ -60,6 +60,12 @@ variable "apiary_log_prefix" { | |||
| default = "" | |||
| } | |||
|
|
|||
| variable "apiary_cloudwatch_logs_retention_days" { | |||
| description = "Log retention in days for the Apiary ECS cloudwatch log group." | |||
There was a problem hiding this comment.
Suggested change
| description = "Log retention in days for the Apiary ECS cloudwatch log group." | |
| description = "Log retention in days for the Apiary ECS CloudWatch log group." |
massdosage
approved these changes
May 13, 2020
barnharts4
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s of the apiary cloudwatch log group. The default is 30 days.