-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no exit code as counter #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
Tested it locally and it works as expected.
I made a couple of comments/questions
@pnu-s ? |
Sorry for the delayed answer! My proposal was not just to use the That would improve the user experience in my opinion In terms of code, it would mean:
|
See new commit if all([counter, forced_code is not None]):
sys.exit(forced_code)
sys.exit(counter) 0 is False in Python. If counter is not zero (has trackers) AND code overwriting is set to any int value, the value will be used else counter. |
LGTM, thanks for your quick changes! You'll just need to remove that extra blank line to make the linter pass, and I'll be able to merge it 🚀 |
Added flag
--no-exit-counter
that allows get exit code 0 if no any errors appears.