Fix bottom nav showing up in app-reports on orientation changes

[starry-shivam]

Closes #452

[Jean-BaptisteC]

Is it the right fix ?
Bottom bar continue to be visible and disappear after 1 second

[starry-shivam]

Is it the right fix ? Bottom bar continue to be visible and disappear after 1 second

It's because the visibility is set inside the withEndAction() callback in hideBottomNavigation(), which means it waits for the animation to finish and then changes the visibility asynchronously. This results in a split-second delay. This could be fixed by setting the visibility before starting the animation, but doing so would make the animation feel choppy. Personally, I don't think it's a significant issue, as not many people constantly rotate their device while using a certain app, and even if they do, it's not like the bottom navigation bar keeps showing up. Therefore, I think it's not worth breaking the animation just to fix this.

If I come up with a better solution later, maybe I'll create a PR. But for now, I don't know any better solution than this. One reason might be that I haven't worked much with the XML view system, as I primarily work with Jetpack Compose. So, I may lack enough experience to handle this properly.

[Jean-BaptisteC]

Thanks
Maybe one day we migrate to Jetpack Compose ;)