Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate information on tracker detail fragment #382

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

Jean-BaptisteC
Copy link
Contributor

In the tracker detail fragment below the description of the tracker, we show the URL to access to tracker website, but this information can be get by the button at the top right of the screen.
This PR removes textview contain website URL.

@codeurimpulsif
Copy link
Contributor

So this information is now hidden behind a button?

@Jean-BaptisteC
Copy link
Contributor Author

Yes like on the platform
image
I can add a long-click listener on the top button to copy link like on computer with right click.

Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think it's a good idea, I review the code ^^

@Jean-BaptisteC
Copy link
Contributor Author

Done
I use ImageButton instead menu because menu doesn't onLongClickListener.

@Jean-BaptisteC Jean-BaptisteC merged commit 748a0ab into master Jan 23, 2024
1 check passed
@Jean-BaptisteC Jean-BaptisteC deleted the autolink branch January 23, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants