Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter #372

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fix linter #372

merged 1 commit into from
Jan 3, 2024

Conversation

Jean-BaptisteC
Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC commented Jan 2, 2024

Closes #365
Closes #300

  • Add new config linter and disable rules about package name
  • Fix errors generate by linter

disabledRules is depreciated on most recent of linter, but for now new method (use .editorconfig)is not support by the gradle plugin ktlint

Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rapid review, seems ok

@Jean-BaptisteC Jean-BaptisteC force-pushed the linter branch 2 times, most recently from 9a03d4e to f6bd68e Compare January 3, 2024 16:47
@Jean-BaptisteC
Copy link
Contributor Author

I have found a way to use a new format to disable rules
I have set a specific version of Kotlin linter in build.gradle to not break linter each time plugins publish a new release

@Jean-BaptisteC Jean-BaptisteC force-pushed the linter branch 4 times, most recently from 0680f07 to 8d5c0d7 Compare January 3, 2024 17:21
@Jean-BaptisteC Jean-BaptisteC merged commit bfd5896 into master Jan 3, 2024
1 check passed
@Jean-BaptisteC Jean-BaptisteC deleted the linter branch January 3, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linter error
2 participants