Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove description permission on AppDetailFragment #339

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Remove description permission on AppDetailFragment #339

merged 4 commits into from
Dec 8, 2023

Conversation

Jean-BaptisteC
Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC commented Sep 17, 2023 •
edited
Loading

Fixes #240
This PR remove:

  • Description value permission (This information is a long description foreach permission but we have already short description. And remove this information reduce the load of app)
  • Remove expand to see or hide description foreach permission
  • Fix cropping on the first description permission in list
  • Increase end padding and increase maxlines on short description permission
Before After

Todo:

  • Check migration works properly

@Jean-BaptisteC Jean-BaptisteC requested a review from a user October 18, 2023 19:07
codeurimpulsif
codeurimpulsif approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me

@Jean-BaptisteC Jean-BaptisteC merged commit 71efb01 into master Dec 8, 2023
1 check passed
@Jean-BaptisteC Jean-BaptisteC deleted the description_permission branch December 8, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeurimpulsif codeurimpulsif codeurimpulsif approved these changes

@jfoucry jfoucry Awaiting requested review from jfoucry

@pnu-s pnu-s Awaiting requested review from pnu-s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove permission description
2 participants
@Jean-BaptisteC @codeurimpulsif