Improve performance during scrolling of items lists (#385)

* Use method to improve loading of list items * Remove useless scrollview
Exodus-Privacy · Jan 23, 2024 · 17a79e0 · 17a79e0
1 parent bd7b3ea
commit 17a79e0
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 12 deletions.
diff --git a/...org/eu/exodus_privacy/exodusprivacy/fragments/appdetail/subfrags/ADPermissionsFragment.kt b/...org/eu/exodus_privacy/exodusprivacy/fragments/appdetail/subfrags/ADPermissionsFragment.kt
@@ -50,6 +50,7 @@ class ADPermissionsFragment : Fragment(R.layout.fragment_a_d_permissions) {
                                 return false
                             }
                         }
+                        setItemViewCacheSize(10)
                     }
                     adPermissionsRVAdapter.submitList(app.permissions)
                     permissionsStatusTV.text = getString(R.string.code_permission_found)

diff --git a/...va/org/eu/exodus_privacy/exodusprivacy/fragments/appdetail/subfrags/ADTrackersFragment.kt b/...va/org/eu/exodus_privacy/exodusprivacy/fragments/appdetail/subfrags/ADTrackersFragment.kt
@@ -77,6 +77,7 @@ class ADTrackersFragment : Fragment(R.layout.fragment_a_d_trackers) {
                             return false
                         }
                     }
+                    setItemViewCacheSize(10)
                 }
                 val trackersList = arrayListOf<String>()
                 it.forEach { item -> trackersList.add(item.name) }

diff --git a/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/fragments/apps/AppsFragment.kt b/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/fragments/apps/AppsFragment.kt
@@ -88,6 +88,7 @@ class AppsFragment : Fragment(R.layout.fragment_apps) {
                     }
                 },
             )
+            setItemViewCacheSize(10)
         }
 
         // Setup Shimmer Layout

diff --git a/app/src/main/res/layout/fragment_apps.xml b/app/src/main/res/layout/fragment_apps.xml
@@ -36,19 +36,13 @@
         app:layout_constraintTop_toBottomOf="@+id/toolbarApps"
         app:shimmer_direction="left_to_right">
 
-        <ScrollView
-            android:layout_width="match_parent"
-            android:layout_height="match_parent"
-            android:scrollbars="none">
-
             <LinearLayout
                 android:id="@+id/shimmerPlaceHolderLayout"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:orientation="vertical">
 
             </LinearLayout>
-        </ScrollView>
 
     </com.facebook.shimmer.ShimmerFrameLayout>
 

diff --git a/app/src/main/res/layout/fragment_trackers.xml b/app/src/main/res/layout/fragment_trackers.xml
@@ -28,11 +28,6 @@
         app:layout_constraintTop_toBottomOf="@+id/toolbarTrackers"
         app:shimmer_direction="left_to_right">
 
-        <ScrollView
-            android:layout_width="match_parent"
-            android:layout_height="match_parent"
-            android:scrollbars="none">
-
             <LinearLayout
                 android:id="@+id/shimmerPlaceHolderLayout"
                 android:layout_width="match_parent"
@@ -41,7 +36,6 @@
                 android:paddingTop="20dp">
 
             </LinearLayout>
-        </ScrollView>
 
     </com.facebook.shimmer.ShimmerFrameLayout>
-Original file line number
+Diff line change
@@ Expand Up / @@ -88,6 +88,7 @@ class AppsFragment : Fragment(R.layout.fragment_apps) { @@
                         }
                     },
                 )
+                setItemViewCacheSize(10)
             }
             // Setup Shimmer Layout
@@ Expand Down @@