fix: don't use spec for known networks

[MaxMustermann2]

Summary by CodeRabbit

• New Features

  • Introduced a new constant for default slots per epoch.
  • Added a mapping between chain identifiers and their corresponding slots per epoch.

• Bug Fixes

  • Enhanced error handling for configuration and fetching processes, ensuring stricter validation.

• Refactor

  • Updated initialization logic for slots per epoch, allowing dynamic configuration.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the beaconchain.go and types.go files. In beaconchain.go, the slotsPerEpoch variable is redefined to allow dynamic initialization based on configuration, with enhanced error handling that now uses panic instead of returning errors. The GetFinalizedEpoch function has been updated to reflect these changes. In types.go, a new constant DefaultSlotsPerEpoch and a map ChainToSlotsPerEpoch have been added to associate specific chain identifiers with the default slots per epoch value.

Changes

File Path	Change Summary
fetcher/beaconchain/beaconchain.go	- Changed slotsPerEpoch from uint64(32) to uint64 for dynamic initialization. - Enhanced error handling using panic for configuration parsing, URL parsing, and fetching slotsPerEpoch. - Updated GetFinalizedEpoch to use the new slotsPerEpoch.
fetcher/types/types.go	- Added constant DefaultSlotsPerEpoch of type uint64 with value 32. - Introduced variable ChainToSlotsPerEpoch as a map associating specific uint64 keys with DefaultSlotsPerEpoch.

Sequence Diagram(s)

sequenceDiagram
    participant Config as Configuration
    participant Beacon as BeaconChain
    participant Epoch as Epoch Calculation

    Config->>Beacon: Initialize with NSTID
    Beacon->>Beacon: Validate NSTID format
    Beacon->>Beacon: Set slotsPerEpoch dynamically
    Beacon->>Epoch: Calculate Finalized Epoch
    Epoch->>Beacon: Return Finalized Epoch

Loading

🐰 In the code, a change we see,
Slots per epoch, now set dynamically!
With errors caught in a panic's embrace,
A clearer path, a more robust space.
Constants and maps, new ties we weave,
In the world of chains, we believe! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 650f1bd and b81b500.

📒 Files selected for processing (2)

• fetcher/beaconchain/beaconchain.go (3 hunks)
• fetcher/types/types.go (1 hunks)

🔇 Additional comments (2)

fetcher/types/types.go (2)

13-13: Define DefaultSlotsPerEpoch for clarity and configurability

Adding DefaultSlotsPerEpoch as a constant enhances clarity and allows for easier configuration management.

---

17-21: Initialize ChainToSlotsPerEpoch map correctly

The ChainToSlotsPerEpoch map is properly initialized, associating specific chain IDs with DefaultSlotsPerEpoch.